kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix(assembly): move resetSolver() out-of-line to fix incomplete type error #305

Merged
forbes merged 1 commits from fix/resetsolver-incomplete-type into main 2026-02-21 13:09:44 +00:00
Conversation 0 Commits 1 Files Changed 2 +6 -1
forbes commented 2026-02-21 13:09:11 +00:00
Owner
Copy Link

unique_ptr::reset() requires the complete type for its deleter, but IKCSolver is only forward-declared in AssemblyObject.h. Move the definition to AssemblyObject.cpp where the full header is included.

Fixes the build break introduced in #303.

unique_ptr::reset() requires the complete type for its deleter, but IKCSolver is only forward-declared in AssemblyObject.h. Move the definition to AssemblyObject.cpp where the full header is included. Fixes the build break introduced in #303.
forbes added 1 commit 2026-02-21 13:09:12 +00:00
fix(assembly): move resetSolver() out-of-line to fix incomplete type error
Some checks failed
Build and Test / build (pull_request) Has been cancelled
Details
6e7d2b582e 
unique_ptr::reset() requires the complete type for its deleter, but
IKCSolver is only forward-declared in AssemblyObject.h. Move the
definition to AssemblyObject.cpp where the full header is included.
forbes merged commit ae576629c5 into main 2026-02-21 13:09:44 +00:00
forbes deleted branch fix/resetsolver-incomplete-type 2026-02-21 13:09:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
UX
branding
bug
ci/cd
CI/CD workflows and deployment
 defaults
documentation
Developer documentation
 enhancement
high-priority
low-priority
theme
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/create#305
Delete Branch "fix/resetsolver-incomplete-type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?