fix: update silo submodule — SSE URL and origin command fixes (#84) #85

forbes · 2026-02-09T04:55:00Z

forbes commented

2026-02-09 04:55:00 +00:00

Fixes two bugs in the Silo workbench:

SSE reconnection loop: _listen() constructed the URL as ${api_url}/api/events but _get_api_url() already returns a URL ending in /api, producing /api/api/events. Changed to /events to match _test_sse().
SiloOrigin command invocation: All 8 calls to FreeCADGui.Command.get("Silo_*").Activated() failed because the C++ Gui::Command wrapper doesn't expose .Activated() to Python. Replaced with FreeCADGui.runCommand().

Closes #84

Fixes two bugs in the Silo workbench: 1. **SSE reconnection loop**: `_listen()` constructed the URL as `${api_url}/api/events` but `_get_api_url()` already returns a URL ending in `/api`, producing `/api/api/events`. Changed to `/events` to match `_test_sse()`. 2. **SiloOrigin command invocation**: All 8 calls to `FreeCADGui.Command.get("Silo_*").Activated()` failed because the C++ `Gui::Command` wrapper doesn't expose `.Activated()` to Python. Replaced with `FreeCADGui.runCommand()`. Closes #84

forbes added 1 commit 2026-02-09 04:55:01 +00:00

fix: update silo submodule — SSE URL and origin command fixes (#84 )

Build and Test / build (pull_request) Has been cancelled

Details

353efe51e2

- Fix SSE listener double /api/ URL causing reconnection loop
- Replace Command.get().Activated() with runCommand() in SiloOrigin

Closes #84

forbes merged commit a9de667914 into main

2026-02-09 04:55:17 +00:00

forbes deleted branch fix/silo-sse-and-origin

2026-02-09 04:55:17 +00:00

forbes referenced this issue from a commit

2026-02-09 04:55:18 +00:00

Merge pull request 'fix: update silo submodule — SSE URL and origin command fixes (#84)' (#85) from fix/silo-sse-and-origin into main

forbes referenced this pull request

2026-02-10 00:41:07 +00:00

fix: update silo submodule — save Modified attribute fix #129

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kindred/create#85