Every time the InvoluteGearFeature python module was imported, and we're in GUI context, the command "PartDesign_InvoluteGear" was registered. On the 2nd (3rd, ...) time, this was reported as an error in the console, like "error: Command.cpp(1841): duplicate command PartDesign_InvoluteGear" The first import happens when the PartDesign FreeCAD Module is loaded, via `InitGui.py`. Subsequent imports may happen when e.g. executing the involute gear command or when running it's tests via FC's Test WB. This change now registers the command only then the PartDesign WB is set up in InitGui, not when importing the python module. The same fix is applied for sprocket, where the same pattern for command registration was used. In addition, the import error catch was removed, which seems to be a copy paste left-over from the ShaftWizard. In contrast to ShaftWizard, involute gear and sprocket only use modules from the Python standard lib, so I think this precaution is not worth the additional complexity, just for hiding actual errors.
66 lines
3.1 KiB
Python
66 lines
3.1 KiB
Python
#***************************************************************************
|
|
#* Copyright (c) 2002,2003 Juergen Riegel <juergen.riegel@web.de> *
|
|
#* *
|
|
#* This file is part of the FreeCAD CAx development system. *
|
|
#* *
|
|
#* This program is free software; you can redistribute it and/or modify *
|
|
#* it under the terms of the GNU Lesser General Public License (LGPL) *
|
|
#* as published by the Free Software Foundation; either version 2 of *
|
|
#* the License, or (at your option) any later version. *
|
|
#* for detail see the LICENCE text file. *
|
|
#* *
|
|
#* FreeCAD is distributed in the hope that it will be useful, *
|
|
#* but WITHOUT ANY WARRANTY; without even the implied warranty of *
|
|
#* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
|
|
#* GNU Lesser General Public License for more details. *
|
|
#* *
|
|
#* You should have received a copy of the GNU Library General Public *
|
|
#* License along with FreeCAD; if not, write to the Free Software *
|
|
#* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 *
|
|
#* USA *
|
|
#* *
|
|
#***************************************************************************/
|
|
|
|
# PartDesign gui init module
|
|
#
|
|
# Gathering all the information to start FreeCAD
|
|
# This is the second one of three init scripts, the third one
|
|
# runs when the gui is up
|
|
|
|
class PartDesignWorkbench ( Workbench ):
|
|
"PartDesign workbench object"
|
|
def __init__(self):
|
|
self.__class__.Icon = FreeCAD.getResourceDir() + "Mod/PartDesign/Resources/icons/PartDesignWorkbench.svg"
|
|
self.__class__.MenuText = "Part Design"
|
|
self.__class__.ToolTip = "Part Design workbench"
|
|
|
|
def Initialize(self):
|
|
# load the module
|
|
try:
|
|
import traceback
|
|
from PartDesign.WizardShaft import WizardShaft
|
|
except RuntimeError:
|
|
print ("{}".format(traceback.format_exc()))
|
|
except ImportError:
|
|
print("Wizard shaft module cannot be loaded")
|
|
try:
|
|
from FeatureHole import HoleGui
|
|
except Exception:
|
|
pass
|
|
|
|
import PartDesignGui
|
|
import PartDesign
|
|
|
|
from PartDesign.InvoluteGearFeature import CommandInvoluteGear
|
|
Gui.addCommand('PartDesign_InvoluteGear', CommandInvoluteGear())
|
|
|
|
from PartDesign.SprocketFeature import CommandSprocket
|
|
FreeCADGui.addCommand('PartDesign_Sprocket', CommandSprocket())
|
|
|
|
def GetClassName(self):
|
|
return "PartDesignGui::Workbench"
|
|
|
|
Gui.addWorkbench(PartDesignWorkbench())
|
|
|
|
FreeCAD.__unit_test__ += [ "TestPartDesignGui" ]
|