kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
Files
6d112214616c1a7a85b7ed8723e936b76c41d768
create/src/App
History
Joao Matos e5dad52fdf App: Invoke signalBeforeRecompute() on the GUI thread 
Historically, `App::Document::recompute()` ran entirely on the **main**
(GUI) thread and directly emitted `signalBeforeRecompute()`.

* Add-ons like **Assembly3** and others depend on that signal for
setup/teardown hooks before any recompute work begins.

* After offloading `recompute()` into a background worker thread to keep
the UI responsive, calling `signalBeforeRecompute()` directly from the
worker would break thread-affinity rules and silently break
compatibility with those add-ons.

**Solution**

1. **Introduce a generic hook** (`PreRecomputeHook`) in
**App::Document**:

* A `std::function<void()>` that, if set, is invoked at the very
start of `recompute()`.

* Core code stays Qt-free—only knows to call a callback if one
exists.

2. **Wire up the hook in `Gui::Document`**:

* In the GUI wrapper’s constructor, install a hook that calls
`callSignalBeforeRecompute()`.

* `callSignalBeforeRecompute()` uses `QMetaObject::invokeMethod(...,
Qt::BlockingQueuedConnection)` to enqueue `signalBeforeRecompute()` on
the GUI thread and **block** the worker until it completes.

    * If already on the GUI thread, it simply calls the signal directly.

3. **Maintain add-on compatibility**:

* From the add-on’s perspective nothing changes—they still receive
`signalBeforeRecompute()` on the main thread before any recompute work.

* Internally, the recompute body now runs on a worker thread,
improving UI responsiveness without breaking existing hooks.

**Result**

* **Recompute** remains fully backward-compatible for add-ons like
Assembly3.

* **UI thread** still handles all GUI-related signaling.

* **Worker thread** performs the actual heavy lifting, unblocked only
once the GUI is primed and all pre-recompute signals have been
delivered.
2025-05-19 18:30:56 +02:00
..
private
App: Invoke signalBeforeRecompute() on the GUI thread
2025-05-19 18:30:56 +02:00
Resources
Translations (#18923)
2025-01-13 21:30:30 -06:00
Annotation.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Annotation.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Application.cpp
Add Navigation Style/Orbit Style/Rotation Mode to About info
2025-05-19 17:45:00 +02:00
Application.h
App: Running FreeCAD in verbose mode information to reflect Gui -> Help -> About Dialog info (#20487)
2025-04-16 08:29:07 +02:00
ApplicationPy.cpp
Console: rename PascalCase named methods to camelCase
2025-05-06 17:50:21 +02:00
AutoTransaction.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
AutoTransaction.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Branding.cpp
App: Use contains instead of std::find
2025-05-03 22:22:10 +02:00
Branding.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
CleanupProcess.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
CleanupProcess.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
CMakeLists.txt
App: cmake: add missing Coin_INCLUDE_DIR after #20487 (#20863)
2025-04-21 15:01:03 -03:00
ColorModel.cpp
Base: Move App::Color to Base
2025-02-17 21:10:26 +01:00
ColorModel.h
Base: Move App::Color to Base
2025-02-17 21:10:26 +01:00
ComplexGeoData.cpp
Merge pull request #19907 from benj5378/getAttribute
2025-05-12 10:39:55 -05:00
ComplexGeoData.h
App: Coverity fixes
2025-03-18 15:59:22 +01:00
ComplexGeoData.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
ComplexGeoDataPyImp.cpp
python: apply const method annotations to impls.
2025-04-16 20:32:04 -07:00
core-app.dox
Doc: Improve PropertyContainer documentation
2025-04-29 22:50:14 -05:00
Datums.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
Datums.h
Use longest edge in face for horizontal/vertical alignment (#20374)
2025-04-14 11:20:49 -05:00
Document.cpp
App: Invoke signalBeforeRecompute() on the GUI thread
2025-05-19 18:30:56 +02:00
Document.h
App: Invoke signalBeforeRecompute() on the GUI thread
2025-05-19 18:30:56 +02:00
Document.pyi
Core: Fixed a bug where an empty document disappears (#20554)
2025-04-28 10:46:52 -05:00
DocumentObject.cpp
Core: restoreContent not restoring expressions (#21152)
2025-05-06 12:02:35 -05:00
DocumentObject.h
Core: restoreContent not restoring expressions (#21152)
2025-05-06 12:02:35 -05:00
DocumentObject.pyi
Add locked keyword argument to DocumentObject::addProperty
2025-04-22 23:52:17 +02:00
DocumentObjectExtension.cpp
Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
2025-01-27 16:08:18 +01:00
DocumentObjectExtension.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
DocumentObjectExtension.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
DocumentObjectExtensionPyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
DocumentObjectFileIncluded.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
DocumentObjectFileIncluded.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
DocumentObjectGroup.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
DocumentObjectGroup.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
DocumentObjectGroup.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
DocumentObjectGroupPyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
DocumentObjectPyImp.cpp
Add locked keyword argument to DocumentObject::addProperty
2025-04-22 23:52:17 +02:00
DocumentObserver.cpp
Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
2025-01-27 16:08:18 +01:00
DocumentObserver.h
Base: Use explicit pointer syntax for freecad_cast (#20694)
2025-04-11 14:11:33 +00:00
DocumentObserverPython.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
DocumentObserverPython.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
DocumentPyImp.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
DynamicProperty.cpp
Merge pull request #19907 from benj5378/getAttribute
2025-05-12 10:39:55 -05:00
DynamicProperty.h
Address performance of existing unique-name generation (Part 2) (#18676)
2025-02-24 10:23:53 -06:00
ElementMap.cpp
Fix to sanity checking of ElementMap::restore()
2025-04-23 17:19:32 -05:00
ElementMap.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
ElementNamingUtils.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
ElementNamingUtils.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Enumeration.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Enumeration.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Expression.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
Expression.h
Base: Use explicit pointer syntax for freecad_cast (#20694)
2025-04-11 14:11:33 +00:00
Expression.l
App: Expression: rename lexer and parser files
2025-04-08 11:10:50 +02:00
Expression.lex.c
App: Expression: rename lexer and parser files
2025-04-08 11:10:50 +02:00
Expression.tab.c
App: Expression: rename lexer and parser files
2025-04-08 11:10:50 +02:00
Expression.tab.h
App: Expression: rename lexer and parser files
2025-04-08 11:10:50 +02:00
Expression.y
App: Expression: rename lexer and parser files
2025-04-08 11:10:50 +02:00
ExpressionParser.h
[Doc] Process comments from review
2025-04-22 13:42:50 +02:00
ExpressionParser.sh
App: Expression: rename lexer and parser files
2025-04-08 11:10:50 +02:00
ExpressionTokenizer.cpp
App: Coverity fixes
2025-03-18 15:59:22 +01:00
ExpressionTokenizer.h
App: Apply clang format (part 2)
2024-11-21 21:17:42 +01:00
ExpressionVisitors.h
App: Apply clang format (part 2)
2024-11-21 21:17:42 +01:00
Extension.cpp
Merge pull request #19583 from hyarion/refactor/base-type
2025-03-17 00:03:22 -05:00
Extension.h
Doc: Improve App::Extension documentation
2025-05-08 17:52:33 -05:00
Extension.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
ExtensionContainer.cpp
Merge pull request #19907 from benj5378/getAttribute
2025-05-12 10:39:55 -05:00
ExtensionContainer.h
Doc: Fix small doc warnings in ExtensionContainer
2025-05-08 17:52:33 -05:00
ExtensionContainer.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
ExtensionContainerPyImp.cpp
python: apply const method annotations to impls.
2025-04-16 20:32:04 -07:00
ExtensionPyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
ExtensionPython.h
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
FeatureCustom.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
FeaturePython.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
FeaturePython.h
[Doc] Improve documentation PropertyContainer
2025-04-22 13:42:50 +02:00
FeaturePythonPyImp.h
Removed old Python code <3.10
2025-03-07 16:34:08 -06:00
FeaturePythonPyImp.inl
Removed old Python code <3.10
2025-03-07 16:34:08 -06:00
FeatureTest.cpp
Console: rename PascalCase named methods to camelCase
2025-05-06 17:50:21 +02:00
FeatureTest.h
App: Apply clang format (part 2)
2024-11-21 21:17:42 +01:00
FreeCADInit.py
Macro: allow to specify extra system paths for macro
2025-01-06 18:14:15 +01:00
FreeCADTest.py
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
GeoFeature.cpp
Use longest edge in face for horizontal/vertical alignment (#20374)
2025-04-14 11:20:49 -05:00
GeoFeature.h
Use longest edge in face for horizontal/vertical alignment (#20374)
2025-04-14 11:20:49 -05:00
GeoFeature.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
GeoFeatureGroupExtension.cpp
App: use contains() instead of count() where possible
2025-05-03 22:19:51 +02:00
GeoFeatureGroupExtension.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
GeoFeatureGroupExtension.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
GeoFeatureGroupExtensionPyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
GeoFeaturePyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Graphviz.cpp
App: Use contains instead of std::find
2025-05-03 22:22:10 +02:00
GroupExtension.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
GroupExtension.h
App: Add GroupExtension::addObject<T>(...)
2025-02-10 18:35:38 +01:00
GroupExtension.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
GroupExtensionPyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
ImagePlane.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
ImagePlane.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
IndexedName.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
IndexedName.h
Fix various typos
2025-05-15 10:59:48 -05:00
InventorObject.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
InventorObject.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
License.h
Base: Add isNullOrEmpty string helper
2025-02-21 15:04:43 +01:00
Link.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
Link.h
App: Apply clang format (part 2)
2024-11-21 21:17:42 +01:00
LinkBaseExtension.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
LinkBaseExtensionPyImp.cpp
Base: Standardize on Py::Long type for Python bindings.
2025-02-08 13:14:22 +00:00
LinkParams.py
App: Apply clang format (part 2)
2024-11-21 21:17:42 +01:00
MappedElement.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
MappedElement.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
MappedName.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
MappedName.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Material.cpp
Merge pull request #19636 from kadet1090/color-in-base
2025-03-02 16:36:40 -06:00
Material.h
Base: Move App::Color to Base
2025-02-17 21:10:26 +01:00
Material.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
MaterialObject.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
MaterialObject.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
MaterialPyImp.cpp
Base: Move App::Color to Base
2025-02-17 21:10:26 +01:00
MeasureManager.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
MeasureManager.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
MeasureManager.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
MeasureManagerPyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
MergeDocuments.cpp
Base: remove unneeded includes
2025-02-18 11:07:57 -06:00
MergeDocuments.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Metadata.cpp
Merge pull request #18594 from Flast/performance/base/find_element
2025-02-10 14:33:49 -06:00
Metadata.h
[Doc] Process comments from review
2025-04-22 13:42:50 +02:00
Metadata.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
MetadataPyImp.cpp
Base: Add isNullOrEmpty string helper
2025-02-21 15:04:43 +01:00
ObjectIdentifier.cpp
Doc: Improve App::ObjectIdentifier docs
2025-05-07 13:34:25 +02:00
ObjectIdentifier.h
Fix various typos
2025-05-15 10:59:48 -05:00
Origin.cpp
Core: Add App::LocalCoordinateSystem.
2024-11-26 17:36:02 +01:00
Origin.h
App: Fix const correctness
2025-01-02 13:24:57 +01:00
OriginGroupExtension.cpp
FEM: Make post object placement work
2025-03-22 23:27:10 +01:00
OriginGroupExtension.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
OriginGroupExtension.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
OriginGroupExtensionPyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Part.cpp
Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
2025-01-27 16:08:18 +01:00
Part.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Part.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
PartPyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Path.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Path.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Placement.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Placement.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
PreCompiled.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
PreCompiled.h
App: Use std::numeric_limits and std::numbers instead of defines
2025-03-29 13:32:37 +01:00
ProgramOptionsUtilities.h
[Doc] Process comments from review
2025-04-22 13:42:50 +02:00
ProjectFile.cpp
Base: make getAttribute template
2025-05-09 15:54:57 +02:00
ProjectFile.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Property.cpp
Doc: Improve App::Property documentation
2025-05-06 12:00:52 -05:00
Property.h
Doc: Fix warnings App::Property
2025-05-07 15:15:08 +02:00
PropertyContainer.cpp
Merge pull request #19907 from benj5378/getAttribute
2025-05-12 10:39:55 -05:00
PropertyContainer.h
Doc: Improve PropertyContainer documentation
2025-04-29 22:50:14 -05:00
PropertyContainer.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
PropertyContainerPyImp.cpp
App: Use freecad_cast whenever possible
2025-04-26 14:23:25 +02:00
PropertyExpressionEngine.cpp
Merge pull request #19907 from benj5378/getAttribute
2025-05-12 10:39:55 -05:00
PropertyExpressionEngine.h
change MIN_boost_version
2025-02-15 13:33:32 -06:00
PropertyFile.cpp
Merge pull request #19907 from benj5378/getAttribute
2025-05-12 10:39:55 -05:00
PropertyFile.h
App: Apply clang format (part 2)
2024-11-21 21:17:42 +01:00
PropertyGeo.cpp
Base: make getAttribute template
2025-05-09 15:54:57 +02:00
PropertyGeo.h
App: Apply clang format (part 2)
2024-11-21 21:17:42 +01:00
PropertyLinks.cpp
Merge pull request #19907 from benj5378/getAttribute
2025-05-12 10:39:55 -05:00
PropertyLinks.h
Doc: Improve App::ObjectIdentifier docs
2025-05-07 13:34:25 +02:00
PropertyPythonObject.cpp
Merge pull request #19907 from benj5378/getAttribute
2025-05-12 10:39:55 -05:00
PropertyPythonObject.h
App: Apply clang format (part 2)
2024-11-21 21:17:42 +01:00
PropertyStandard.cpp
Merge pull request #19907 from benj5378/getAttribute
2025-05-12 10:39:55 -05:00
PropertyStandard.h
Base: Move App::Color to Base
2025-02-17 21:10:26 +01:00
PropertyUnits.cpp
App: Add #include <limits> where used
2025-03-31 23:50:19 +02:00
PropertyUnits.h
Base: Add volume charge density unit
2025-03-27 21:13:21 +01:00
Range.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Range.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
SafeMode.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
SafeMode.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Services.cpp
MSVC: Add missing PreCompiled.h includes
2025-01-14 09:28:47 +01:00
Services.h
Gui: Rework TaskCSysDragger into new Transform Dialog
2025-01-04 16:32:52 +01:00
StringHasher.cpp
Fix various typos
2025-05-15 10:59:48 -05:00
StringHasher.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
StringHasher.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
StringHasherPyImp.cpp
python: apply const method annotations to impls.
2025-04-16 20:32:04 -07:00
StringID.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
StringIDPyImp.cpp
python: apply const method annotations to impls.
2025-04-16 20:32:04 -07:00
SuppressibleExtension.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
SuppressibleExtension.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
SuppressibleExtension.pyi
App: Modernize Python bindings with new API model.
2025-03-20 11:07:27 +01:00
SuppressibleExtensionPyImp.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
TextDocument.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
TextDocument.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
TransactionalObject.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
TransactionalObject.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
Transactions.cpp
Base: rename Exception's PascalCase methods to camelCase
2025-05-05 23:50:01 +02:00
Transactions.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
VarSet.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
VarSet.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
VRMLObject.cpp
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00
VRMLObject.h
App: Apply clang format (part 1)
2024-11-21 07:54:24 +01:00