Files
create/src/App/ExtensionContainer.cpp
Kevin Martin 5696c9add3 Address the poor performance of the existing unique-name generation (#17944)
* Address the poor performance of the existing unique-name generation

As described in Issue 16849, the existing Tools::getUniqueName method
requires calling code to form a vector of existing names to be avoided.

This leads to poor performance both in the O(n) cost of building such a
vector and also getUniqueName's O(n) algorithm for actually generating
the unique name (where 'n' is the number of pre-existing names).

This has  particularly noticeable cost in documents with large numbers
of DocumentObjects because generating both Names and Labels for each new
object incurs this cost. During an operation such as importing this
results in an O(n^2) time spent generating names.

The other major cost is in the saving of the temporary backup file,
which uses name generation for the "files" embedded in the Zip file.
Documents can easily need several such "files" for each object in the
document.

This update includes the following changes:

Create UniqueNameManager to keep a list of existing names organized in
a manner that eases unique-name generation. This class essentially acts
as a set of names, with the ability to add and remove names and check if
a name is already there, with the added ability to take a prototype name
and generate a unique form for it which is not already in the set.

Eliminate Tools::getUniqueName

Make DocumentObject naming use the new UniqueNameManager class

Make DocumentObject Label naming use the new UniqueNameManager class.
Labels are not always unique; unique labels are generated if the
settings at the time request it (and other conditions). Because of this
the Label management requires additionally keeping a map of counts
for labels which already exist more than once.
These collections are maintained via notifications of value changes on
the Label properties of the objects in the document.

Add Document::containsObject(DocumentObject*) for a definitive
test of an object being in a Document. This is needed because
DocumentObjects can be in a sort of limbo (e.g. when they are in the
Undo/Redo lists) where they have a parent linkage to the Document but
should not participate in Label collision checks.

Rename Document.getStandardObjectName to getStandardObjectLabel
to better represent what it does.

Use new UniqueNameManager for Writer internal filenames within the zip
file.

Eliminate unneeded Reader::FileNames collection. The file names
already exist in the FileList collection elements. The only existing
use for the FileNames collection was to determine if there were any
files at all, and with FileList and FileNames being parallel
vectors, they both had the same length so FileList could be used
for this test..

Use UniqueNameManager for document names and labels. This uses ad hoc
UniqueNameManager objects created on the spot on the assumption that
document creation is relatively rare and there are few documents, so
although the cost is O(n), n itself is small.

Use an ad hoc UniqueNameManager to name new DymanicProperty entries.
This is only done if a property of the proposed name already exists,
since such a check is more-or-less O(log(n)), almost never finds a
collision, and avoids the O(n) building of the UniqueNameManager.
If there is a collision an ad-hoc UniqueNameManager is built
and discarded after use.
The property management classes have a bit of a mess of methods
including several to populate various collection types with all
existing properties. Rather than introducing yet another such
collection-specific method to fill a UniqueNameManager, a
visitProperties method was added which calls a passed function for
each property. The existing code would be simpler if existing
fill-container methods all used this.
Ideally the PropertyContainer class would keep a central directory of
all properties ("static", Dynamic, and exposed by ExtensionContainer and
other derivations) and a permanent UniqueNameManager. However the
Property management is a bit of a mess making such a change a project
unto itself.

The unit tests for Tools:getUniqueName have been changed to test
UniqueNameManager.makeUniqueName instead.
This revealed a small regression insofar as passing a prototype name
like "xyz1234" to the old code would yield "xyz1235" whether or
not "xyz1234" already existed, while the new code will return the next
name above the currently-highest name on the "xyz" model, which could
be "xyz" or "xyz1".

* Correct wrong case on include path

* Implement suggested code changes
Also change the semantics of visitProperties to not have any short-circuit return

* Remove reference through undefined iterator

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix up some comments for DOxygen

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-12-13 10:54:46 -06:00

519 lines
16 KiB
C++

/***************************************************************************
* Copyright (c) 2016 Stefan Tröger <stefantroeger@gmx.net> *
* *
* This file is part of the FreeCAD CAx development system. *
* *
* This library is free software; you can redistribute it and/or *
* modify it under the terms of the GNU Library General Public *
* License as published by the Free Software Foundation; either *
* version 2 of the License, or (at your option) any later version. *
* *
* This library is distributed in the hope that it will be useful, *
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
* GNU Library General Public License for more details. *
* *
* You should have received a copy of the GNU Library General Public *
* License along with this library; see the file COPYING.LIB. If not, *
* write to the Free Software Foundation, Inc., 59 Temple Place, *
* Suite 330, Boston, MA 02111-1307, USA *
* *
***************************************************************************/
#include "PreCompiled.h"
#include <Base/Console.h>
#include <Base/Exception.h>
#include <Base/Reader.h>
#include <Base/Writer.h>
#include "Extension.h"
#include "ExtensionContainer.h"
using namespace App;
TYPESYSTEM_SOURCE(App::ExtensionContainer, App::PropertyContainer)
ExtensionContainer::ExtensionContainer() = default;
ExtensionContainer::~ExtensionContainer()
{
// we need to delete all dynamically added extensions
for (const auto& entry : _extensions) {
if (entry.second->isPythonExtension()) {
delete entry.second;
}
}
}
void ExtensionContainer::registerExtension(Base::Type extension, Extension* ext)
{
if (ext->getExtendedContainer() != this) {
throw Base::ValueError(
"ExtensionContainer::registerExtension: Extension has not this as base object");
}
// no duplicate extensions (including base classes)
if (hasExtension(extension)) {
for (const auto& entry : _extensions) {
if (entry.first == extension || entry.first.isDerivedFrom(extension)) {
_extensions.erase(entry.first);
break;
}
}
}
_extensions[extension] = ext;
}
bool ExtensionContainer::hasExtension(Base::Type t, bool derived) const
{
// check for the exact type
bool found = _extensions.find(t) != _extensions.end();
if (!found && derived) {
// and for types derived from it, as they can be cast to the extension
for (const auto& entry : _extensions) {
if (entry.first.isDerivedFrom(t)) {
return true;
}
}
return false;
}
return found;
}
bool ExtensionContainer::hasExtension(const std::string& name) const
{
// and for types derived from it, as they can be cast to the extension
for (const auto& entry : _extensions) {
if (entry.second->name() == name) {
return true;
}
}
return false;
}
Extension* ExtensionContainer::getExtension(Base::Type t, bool derived, bool no_except) const
{
auto result = _extensions.find(t);
if ((result == _extensions.end()) && derived) {
// we need to check for derived types
for (const auto& entry : _extensions) {
if (entry.first.isDerivedFrom(t)) {
return entry.second;
}
}
if (no_except) {
return nullptr;
}
// if we arrive here we don't have anything matching
throw Base::TypeError(
"ExtensionContainer::getExtension: No extension of given type available");
}
else if (result != _extensions.end()) {
return result->second;
}
else {
if (no_except) {
return nullptr;
}
// if we arrive here we don't have anything matching
throw Base::TypeError(
"ExtensionContainer::getExtension: No extension of given type available");
}
}
bool ExtensionContainer::hasExtensions() const
{
return !_extensions.empty();
}
Extension* ExtensionContainer::getExtension(const std::string& name) const
{
// and for types derived from it, as they can be cast to the extension
for (const auto& entry : _extensions) {
if (entry.second->name() == name) {
return entry.second;
}
}
return nullptr;
}
std::vector<Extension*> ExtensionContainer::getExtensionsDerivedFrom(Base::Type type) const
{
std::vector<Extension*> vec;
// and for types derived from it, as they can be cast to the extension
for (const auto& entry : _extensions) {
if (entry.first.isDerivedFrom(type)) {
vec.push_back(entry.second);
}
}
return vec;
}
void ExtensionContainer::getPropertyList(std::vector<Property*>& List) const
{
App::PropertyContainer::getPropertyList(List);
for (const auto& entry : _extensions) {
entry.second->extensionGetPropertyList(List);
}
}
void ExtensionContainer::getPropertyMap(std::map<std::string, Property*>& Map) const
{
App::PropertyContainer::getPropertyMap(Map);
for (const auto& entry : _extensions) {
entry.second->extensionGetPropertyMap(Map);
}
}
void ExtensionContainer::visitProperties(std::function<void(Property*)> visitor) const
{
App::PropertyContainer::visitProperties(visitor);
for(const auto &entry : _extensions) {
entry.second->extensionVisitProperties(visitor);
};
}
Property* ExtensionContainer::getPropertyByName(const char* name) const
{
auto prop = App::PropertyContainer::getPropertyByName(name);
if (prop) {
return prop;
}
for (const auto& entry : _extensions) {
auto prop = entry.second->extensionGetPropertyByName(name);
if (prop) {
return prop;
}
}
return nullptr;
}
short int ExtensionContainer::getPropertyType(const Property* prop) const
{
short int res = App::PropertyContainer::getPropertyType(prop);
if (res != 0) {
return res;
}
for (const auto& entry : _extensions) {
res = entry.second->extensionGetPropertyType(prop);
if (res != 0) {
return res;
}
}
return 0;
}
short int ExtensionContainer::getPropertyType(const char* name) const
{
short int res = App::PropertyContainer::getPropertyType(name);
if (res != 0) {
return res;
}
for (const auto& entry : _extensions) {
res = entry.second->extensionGetPropertyType(name);
if (res != 0) {
return res;
}
}
return 0;
}
const char* ExtensionContainer::getPropertyName(const Property* prop) const
{
const char* res = App::PropertyContainer::getPropertyName(prop);
if (res) {
return res;
}
for (const auto& entry : _extensions) {
res = entry.second->extensionGetPropertyName(prop);
if (res) {
return res;
}
}
return nullptr;
}
const char* ExtensionContainer::getPropertyGroup(const Property* prop) const
{
const char* res = App::PropertyContainer::getPropertyGroup(prop);
if (res) {
return res;
}
for (const auto& entry : _extensions) {
res = entry.second->extensionGetPropertyGroup(prop);
if (res) {
return res;
}
}
return nullptr;
}
const char* ExtensionContainer::getPropertyGroup(const char* name) const
{
const char* res = App::PropertyContainer::getPropertyGroup(name);
if (res) {
return res;
}
for (const auto& entry : _extensions) {
res = entry.second->extensionGetPropertyGroup(name);
if (res) {
return res;
}
}
return nullptr;
}
const char* ExtensionContainer::getPropertyDocumentation(const Property* prop) const
{
const char* res = App::PropertyContainer::getPropertyDocumentation(prop);
if (res) {
return res;
}
for (const auto& entry : _extensions) {
res = entry.second->extensionGetPropertyDocumentation(prop);
if (res) {
return res;
}
}
return nullptr;
}
const char* ExtensionContainer::getPropertyDocumentation(const char* name) const
{
const char* res = App::PropertyContainer::getPropertyDocumentation(name);
if (res) {
return res;
}
for (const auto& entry : _extensions) {
res = entry.second->extensionGetPropertyDocumentation(name);
if (res) {
return res;
}
}
return nullptr;
}
void ExtensionContainer::onChanged(const Property* prop)
{
// inform all extensions about changed property. This includes all properties from the
// extended object (this) as well as all extension properties
for (const auto& entry : _extensions) {
entry.second->extensionOnChanged(prop);
}
App::PropertyContainer::onChanged(prop);
}
void ExtensionContainer::Save(Base::Writer& writer) const
{
// Note: save extensions must be called first to ensure that the extension element is always the
// very first inside the object element. This is needed since extension element works
// together with an object attribute, and if another element would be read first the
// object attributes would be cleared.
saveExtensions(writer);
App::PropertyContainer::Save(writer);
}
void ExtensionContainer::Restore(Base::XMLReader& reader)
{
// restore dynamic extensions.
// Note 1: The extension element must be read first, before all other object elements. That is
// needed as the element works together with an object element attribute, which would be
// cleared if another attribute is read first
// Note 2: This must happen before the py object of this container is used, as only in the
// pyobject constructor the extension methods are added to the container.
restoreExtensions(reader);
App::PropertyContainer::Restore(reader);
}
void ExtensionContainer::saveExtensions(Base::Writer& writer) const
{
// we don't save anything if there are no dynamic extensions
if (!hasExtensions()) {
return;
}
// save dynamic extensions
writer.incInd(); // indentation for 'Extensions'
writer.Stream() << writer.ind() << "<Extensions Count=\"" << _extensions.size() << "\">"
<< std::endl;
for (const auto& entry : _extensions) {
auto ext = entry.second;
writer.incInd(); // indentation for 'Extension name'
writer.Stream() << writer.ind() << "<Extension"
<< " type=\"" << ext->getExtensionTypeId().getName() << "\""
<< " name=\"" << ext->name() << "\">" << std::endl;
writer.incInd(); // indentation for the actual Extension
try {
// We must make sure to handle all exceptions accordingly so that
// the project file doesn't get invalidated. In the error case this
// means to proceed instead of aborting the write operation.
ext->extensionSave(writer);
}
catch (const Base::Exception& e) {
Base::Console().Error("%s\n", e.what());
}
catch (const std::exception& e) {
Base::Console().Error("%s\n", e.what());
}
catch (const char* e) {
Base::Console().Error("%s\n", e);
}
#ifndef FC_DEBUG
catch (...) {
Base::Console().Error(
"ExtensionContainer::Save: Unknown C++ exception thrown. Try to continue...\n");
}
#endif
writer.decInd(); // indentation for the actual extension
writer.Stream() << writer.ind() << "</Extension>" << std::endl;
writer.decInd(); // indentation for 'Extension name'
}
writer.Stream() << writer.ind() << "</Extensions>" << std::endl;
writer.decInd();
}
void ExtensionContainer::restoreExtensions(Base::XMLReader& reader)
{
// Dynamic extensions are optional (also because they are introduced late into the document
// format) and hence it is possible that the element does not exist. As we cannot check for the
// existence of an element a object attribute is set if extensions are available. Here we check
// that attribute, and only if it exists the extensions element will be available.
if (!reader.hasAttribute("Extensions")) {
return;
}
reader.readElement("Extensions");
int Cnt = reader.getAttributeAsInteger("Count");
for (int i = 0; i < Cnt; i++) {
reader.readElement("Extension");
const char* Type = reader.getAttribute("type");
const char* Name = reader.getAttribute("name");
try {
App::Extension* ext = getExtension(Name);
if (!ext) {
// get the extension type asked for
Base::Type extension = Base::Type::fromName(Type);
if (extension.isBad()
|| !extension.isDerivedFrom(App::Extension::getExtensionClassTypeId())) {
std::stringstream str;
str << "No extension found of type '" << Type << "'" << std::ends;
throw Base::TypeError(str.str());
}
// register the extension
ext = static_cast<App::Extension*>(extension.createInstance());
// check if this really is a python extension!
if (!ext->isPythonExtension()) {
delete ext;
std::stringstream str;
str << "Extension is not a python addable version: '" << Type << "'";
throw Base::TypeError(str.str());
}
ext->initExtension(this);
}
if (ext && strcmp(ext->getExtensionTypeId().getName(), Type) == 0) {
ext->extensionRestore(reader);
}
}
catch (const Base::XMLParseException&) {
throw; // re-throw
}
catch (const Base::Exception& e) {
Base::Console().Error("%s\n", e.what());
}
catch (const std::exception& e) {
Base::Console().Error("%s\n", e.what());
}
catch (const char* e) {
Base::Console().Error("%s\n", e);
}
#ifndef FC_DEBUG
catch (...) {
Base::Console().Error("ExtensionContainer::Restore: Unknown C++ exception thrown\n");
}
#endif
reader.readEndElement("Extension");
}
reader.readEndElement("Extensions");
}
void ExtensionContainer::handleChangedPropertyName(Base::XMLReader& reader,
const char* TypeName,
const char* PropName)
{
// inform all extensions about changed property name. This includes all properties from the
// extended object (this) as well as all extension properties
for (const auto& entry : _extensions) {
bool handled = entry.second->extensionHandleChangedPropertyName(reader, TypeName, PropName);
if (handled) {
return; // one property change needs only be handled once
}
}
PropertyContainer::handleChangedPropertyName(reader, TypeName, PropName);
}
void ExtensionContainer::handleChangedPropertyType(Base::XMLReader& reader,
const char* TypeName,
Property* prop)
{
// inform all extensions about changed property type. This includes all properties from the
// extended object (this) as well as all extension properties
for (const auto& entry : _extensions) {
bool handled = entry.second->extensionHandleChangedPropertyType(reader, TypeName, prop);
if (handled) {
return; // one property change needs only be handled once
}
}
PropertyContainer::handleChangedPropertyType(reader, TypeName, prop);
}