Fixes #16564. This reverts commit a7831eee4b.
Co-authored-by: Murmele <Murmele@users.noreply.github.com>
541 lines
16 KiB
C++
541 lines
16 KiB
C++
/***************************************************************************
|
|
* Copyright (c) 2023 David Friedli <david[at]friedli-be.ch> *
|
|
* *
|
|
* This file is part of FreeCAD. *
|
|
* *
|
|
* FreeCAD is free software: you can redistribute it and/or modify it *
|
|
* under the terms of the GNU Lesser General Public License as *
|
|
* published by the Free Software Foundation, either version 2.1 of the *
|
|
* License, or (at your option) any later version. *
|
|
* *
|
|
* FreeCAD is distributed in the hope that it will be useful, but *
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of *
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU *
|
|
* Lesser General Public License for more details. *
|
|
* *
|
|
* You should have received a copy of the GNU Lesser General Public *
|
|
* License along with FreeCAD. If not, see *
|
|
* <https://www.gnu.org/licenses/>. *
|
|
* *
|
|
**************************************************************************/
|
|
|
|
|
|
#include "PreCompiled.h"
|
|
|
|
#ifndef _PreComp_
|
|
#include <QApplication>
|
|
#include <QKeyEvent>
|
|
#endif
|
|
|
|
|
|
#include "TaskMeasure.h"
|
|
|
|
#include <App/DocumentObjectGroup.h>
|
|
#include <App/Link.h>
|
|
#include <Mod/Measure/App/MeasureDistance.h>
|
|
#include <App/PropertyStandard.h>
|
|
#include <Gui/MainWindow.h>
|
|
#include <Gui/Application.h>
|
|
#include <Gui/BitmapFactory.h>
|
|
#include <Gui/Control.h>
|
|
#include <Gui/ViewProviderDocumentObject.h>
|
|
|
|
#include <QFormLayout>
|
|
#include <QPushButton>
|
|
#include <QSettings>
|
|
|
|
using namespace Gui;
|
|
|
|
namespace
|
|
{
|
|
constexpr auto taskMeasureSettingsGroup = "TaskMeasure";
|
|
constexpr auto taskMeasureShowDeltaSettingsName = "ShowDelta";
|
|
} // namespace
|
|
|
|
TaskMeasure::TaskMeasure()
|
|
{
|
|
qApp->installEventFilter(this);
|
|
|
|
this->setButtonPosition(TaskMeasure::South);
|
|
auto taskbox = new Gui::TaskView::TaskBox(Gui::BitmapFactory().pixmap("umf-measurement"),
|
|
tr("Measurement"),
|
|
true,
|
|
nullptr);
|
|
|
|
QSettings settings;
|
|
settings.beginGroup(QLatin1String(taskMeasureSettingsGroup));
|
|
delta = settings.value(QLatin1String(taskMeasureShowDeltaSettingsName), true).toBool();
|
|
|
|
showDelta = new QCheckBox();
|
|
showDelta->setChecked(delta);
|
|
showDeltaLabel = new QLabel(tr("Show Delta:"));
|
|
connect(showDelta, &QCheckBox::stateChanged, this, &TaskMeasure::showDeltaChanged);
|
|
|
|
// Create mode dropdown and add all registered measuretypes
|
|
modeSwitch = new QComboBox();
|
|
modeSwitch->addItem(QString::fromLatin1("Auto"));
|
|
|
|
for (App::MeasureType* mType : App::MeasureManager::getMeasureTypes()) {
|
|
modeSwitch->addItem(QString::fromLatin1(mType->label.c_str()));
|
|
}
|
|
|
|
// Connect dropdown's change signal to our onModeChange slot
|
|
connect(modeSwitch,
|
|
qOverload<int>(&QComboBox::currentIndexChanged),
|
|
this,
|
|
&TaskMeasure::onModeChanged);
|
|
|
|
// Result widget
|
|
valueResult = new QLineEdit();
|
|
valueResult->setReadOnly(true);
|
|
|
|
// Main layout
|
|
QBoxLayout* layout = taskbox->groupLayout();
|
|
|
|
QFormLayout* formLayout = new QFormLayout();
|
|
formLayout->setHorizontalSpacing(10);
|
|
// Note: How can the split between columns be kept in the middle?
|
|
// formLayout->setFieldGrowthPolicy(QFormLayout::FieldGrowthPolicy::ExpandingFieldsGrow);
|
|
formLayout->setFormAlignment(Qt::AlignCenter);
|
|
|
|
formLayout->addRow(tr("Mode:"), modeSwitch);
|
|
formLayout->addRow(showDeltaLabel, showDelta);
|
|
formLayout->addRow(tr("Result:"), valueResult);
|
|
layout->addLayout(formLayout);
|
|
|
|
Content.emplace_back(taskbox);
|
|
|
|
// engage the selectionObserver
|
|
attachSelection();
|
|
|
|
// Set selection style
|
|
Gui::Selection().setSelectionStyle(Gui::SelectionSingleton::SelectionStyle::GreedySelection);
|
|
|
|
if (!App::GetApplication().getActiveTransaction()) {
|
|
App::GetApplication().setActiveTransaction("Add Measurement");
|
|
}
|
|
|
|
|
|
// Call invoke method delayed, otherwise the dialog might not be fully initialized
|
|
QTimer::singleShot(0, this, &TaskMeasure::invoke);
|
|
}
|
|
|
|
TaskMeasure::~TaskMeasure()
|
|
{
|
|
Gui::Selection().setSelectionStyle(Gui::SelectionSingleton::SelectionStyle::NormalSelection);
|
|
detachSelection();
|
|
qApp->removeEventFilter(this);
|
|
}
|
|
|
|
|
|
void TaskMeasure::modifyStandardButtons(QDialogButtonBox* box)
|
|
{
|
|
|
|
QPushButton* btn = box->button(QDialogButtonBox::Apply);
|
|
btn->setText(tr("Save"));
|
|
btn->setToolTip(tr("Save the measurement in the active document."));
|
|
connect(btn, &QPushButton::released, this, &TaskMeasure::apply);
|
|
|
|
// Disable button by default
|
|
btn->setEnabled(false);
|
|
btn = box->button(QDialogButtonBox::Abort);
|
|
btn->setText(tr("Close"));
|
|
btn->setToolTip(tr("Close the measurement task."));
|
|
|
|
// Connect reset button
|
|
btn = box->button(QDialogButtonBox::Reset);
|
|
connect(btn, &QPushButton::released, this, &TaskMeasure::reset);
|
|
}
|
|
|
|
bool canAnnotate(Measure::MeasureBase* obj)
|
|
{
|
|
if (obj == nullptr) {
|
|
// null object, can't annotate this
|
|
return false;
|
|
}
|
|
|
|
auto vpName = obj->getViewProviderName();
|
|
// if there is not a vp, return false
|
|
if ((vpName == nullptr) || (vpName[0] == '\0')) {
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
void TaskMeasure::enableAnnotateButton(bool state)
|
|
{
|
|
// if the task ui is not init yet we don't have a button box.
|
|
if (!this->buttonBox) {
|
|
return;
|
|
}
|
|
// Enable/Disable annotate button
|
|
auto btn = this->buttonBox->button(QDialogButtonBox::Apply);
|
|
btn->setEnabled(state);
|
|
}
|
|
|
|
void TaskMeasure::setMeasureObject(Measure::MeasureBase* obj)
|
|
{
|
|
_mMeasureObject = obj;
|
|
}
|
|
|
|
|
|
App::DocumentObject* TaskMeasure::createObject(const App::MeasureType* measureType)
|
|
{
|
|
auto measureClass =
|
|
measureType->isPython ? "Measure::MeasurePython" : measureType->measureObject;
|
|
auto type = Base::Type::getTypeIfDerivedFrom(measureClass.c_str(),
|
|
App::DocumentObject::getClassTypeId(),
|
|
true);
|
|
|
|
if (type.isBad()) {
|
|
return nullptr;
|
|
}
|
|
|
|
_mMeasureObject = static_cast<Measure::MeasureBase*>(type.createInstance());
|
|
|
|
// Create an instance of the python measure class, the classe's
|
|
// initializer sets the object as proxy
|
|
if (measureType->isPython) {
|
|
Base::PyGILStateLocker lock;
|
|
Py::Tuple args(1);
|
|
args.setItem(0, Py::asObject(_mMeasureObject->getPyObject()));
|
|
PyObject* result = PyObject_CallObject(measureType->pythonClass, args.ptr());
|
|
Py_XDECREF(result);
|
|
}
|
|
|
|
return static_cast<App::DocumentObject*>(_mMeasureObject);
|
|
}
|
|
|
|
|
|
Gui::ViewProviderDocumentObject* TaskMeasure::createViewObject(App::DocumentObject* measureObj)
|
|
{
|
|
// Add view object
|
|
auto vpName = measureObj->getViewProviderName();
|
|
if ((vpName == nullptr) || (vpName[0] == '\0')) {
|
|
return nullptr;
|
|
}
|
|
|
|
auto vpType =
|
|
Base::Type::getTypeIfDerivedFrom(vpName,
|
|
Gui::ViewProviderDocumentObject::getClassTypeId(),
|
|
true);
|
|
if (vpType.isBad()) {
|
|
return nullptr;
|
|
}
|
|
|
|
auto vp = static_cast<Gui::ViewProviderDocumentObject*>(vpType.createInstance());
|
|
|
|
_mGuiDocument = Gui::Application::Instance->activeDocument();
|
|
_mGuiDocument->setAnnotationViewProvider(vp->getTypeId().getName(), vp);
|
|
vp->attach(measureObj);
|
|
|
|
// Init the position of the annotation
|
|
static_cast<MeasureGui::ViewProviderMeasureBase*>(vp)->positionAnno(_mMeasureObject);
|
|
|
|
vp->updateView();
|
|
vp->setActiveMode();
|
|
|
|
_mViewObject = vp;
|
|
return vp;
|
|
}
|
|
|
|
|
|
void TaskMeasure::saveObject()
|
|
{
|
|
if (_mViewObject && _mGuiDocument) {
|
|
_mGuiDocument->addViewProvider(_mViewObject);
|
|
_mGuiDocument->takeAnnotationViewProvider(_mViewObject->getTypeId().getName());
|
|
_mViewObject = nullptr;
|
|
}
|
|
|
|
_mDocument = App::GetApplication().getActiveDocument();
|
|
_mDocument->addObject(_mMeasureObject, _mMeasureType->label.c_str());
|
|
_mMeasureObject = nullptr;
|
|
}
|
|
|
|
|
|
void TaskMeasure::update()
|
|
{
|
|
App::Document* doc = App::GetApplication().getActiveDocument();
|
|
|
|
// Reset selection if the selected object is not valid
|
|
for (auto sel : Gui::Selection().getSelection()) {
|
|
App::DocumentObject* ob = sel.pObject;
|
|
App::DocumentObject* sub = ob->getSubObject(sel.SubName);
|
|
|
|
// Resolve App::Link
|
|
if (sub->isDerivedFrom<App::Link>()) {
|
|
auto link = static_cast<App::Link*>(sub);
|
|
sub = link->getLinkedObject(true);
|
|
}
|
|
|
|
std::string mod = Base::Type::getModuleName(sub->getTypeId().getName());
|
|
if (!App::MeasureManager::hasMeasureHandler(mod.c_str())) {
|
|
Base::Console().Message("No measure handler available for geometry of module: %s\n",
|
|
mod);
|
|
clearSelection();
|
|
return;
|
|
}
|
|
}
|
|
|
|
valueResult->setText(QString::asprintf("-"));
|
|
|
|
// Get valid measure type
|
|
|
|
std::string mode = explicitMode ? modeSwitch->currentText().toStdString() : "";
|
|
|
|
App::MeasureSelection selection;
|
|
for (auto s : Gui::Selection().getSelection(doc->getName(), ResolveMode::NoResolve)) {
|
|
App::SubObjectT sub(s.pObject, s.SubName);
|
|
|
|
App::MeasureSelectionItem item = {sub, Base::Vector3d(s.x, s.y, s.z)};
|
|
selection.push_back(item);
|
|
}
|
|
|
|
auto measureTypes = App::MeasureManager::getValidMeasureTypes(selection, mode);
|
|
if (measureTypes.size() > 0) {
|
|
_mMeasureType = measureTypes.front();
|
|
}
|
|
|
|
|
|
if (!_mMeasureType) {
|
|
|
|
// Note: If there's no valid measure type we might just restart the selection,
|
|
// however this requires enough coverage of measuretypes that we can access all of them
|
|
|
|
// std::tuple<std::string, std::string> sel = selection.back();
|
|
// clearSelection();
|
|
// addElement(measureModule.c_str(), get<0>(sel).c_str(), get<1>(sel).c_str());
|
|
|
|
// Reset measure object
|
|
if (!explicitMode) {
|
|
setModeSilent(nullptr);
|
|
}
|
|
removeObject();
|
|
enableAnnotateButton(false);
|
|
return;
|
|
}
|
|
|
|
// Update tool mode display
|
|
setModeSilent(_mMeasureType);
|
|
|
|
if (!_mMeasureObject
|
|
|| _mMeasureType->measureObject != _mMeasureObject->getTypeId().getName()) {
|
|
// we don't already have a measureobject or it isn't the same type as the new one
|
|
removeObject();
|
|
createObject(_mMeasureType);
|
|
}
|
|
|
|
// we have a valid measure object so we can enable the annotate button
|
|
enableAnnotateButton(true);
|
|
|
|
// Fill measure object's properties from selection
|
|
_mMeasureObject->parseSelection(selection);
|
|
|
|
// Get result
|
|
valueResult->setText(_mMeasureObject->getResultString());
|
|
|
|
createViewObject(_mMeasureObject);
|
|
|
|
// Must be after createViewObject!
|
|
assert(_mViewObject);
|
|
auto* prop = dynamic_cast<App::PropertyBool*>(_mViewObject->getPropertyByName("ShowDelta"));
|
|
setDeltaPossible(prop != nullptr);
|
|
if (prop) {
|
|
prop->setValue(showDelta->isChecked());
|
|
_mViewObject->update(prop);
|
|
}
|
|
}
|
|
|
|
void TaskMeasure::close()
|
|
{
|
|
Control().closeDialog();
|
|
}
|
|
|
|
|
|
void TaskMeasure::ensureGroup(Measure::MeasureBase* measurement)
|
|
{
|
|
// Ensure measurement object is part of the measurements group
|
|
|
|
const char* measurementGroupName = "Measurements";
|
|
if (measurement == nullptr) {
|
|
return;
|
|
}
|
|
|
|
App::Document* doc = measurement->getDocument();
|
|
App::DocumentObject* obj = doc->getObject(measurementGroupName);
|
|
if (!obj || !obj->isValid()) {
|
|
obj = doc->addObject("App::DocumentObjectGroup",
|
|
measurementGroupName,
|
|
true,
|
|
"MeasureGui::ViewProviderMeasureGroup");
|
|
}
|
|
|
|
auto group = static_cast<App::DocumentObjectGroup*>(obj);
|
|
group->addObject(measurement);
|
|
}
|
|
|
|
|
|
// Runs after the dialog is created
|
|
void TaskMeasure::invoke()
|
|
{
|
|
update();
|
|
}
|
|
|
|
bool TaskMeasure::apply()
|
|
{
|
|
saveObject();
|
|
ensureGroup(_mMeasureObject);
|
|
_mMeasureType = nullptr;
|
|
_mMeasureObject = nullptr;
|
|
reset();
|
|
|
|
// Commit transaction
|
|
App::GetApplication().closeActiveTransaction();
|
|
App::GetApplication().setActiveTransaction("Add Measurement");
|
|
return false;
|
|
}
|
|
|
|
bool TaskMeasure::reject()
|
|
{
|
|
removeObject();
|
|
close();
|
|
|
|
// Abort transaction
|
|
App::GetApplication().closeActiveTransaction(true);
|
|
return false;
|
|
}
|
|
|
|
void TaskMeasure::reset()
|
|
{
|
|
// Reset tool state
|
|
_mMeasureType = nullptr;
|
|
this->clearSelection();
|
|
|
|
// Should the explicit mode also be reset?
|
|
// setModeSilent(nullptr);
|
|
// explicitMode = false;
|
|
|
|
this->update();
|
|
}
|
|
|
|
|
|
void TaskMeasure::removeObject()
|
|
{
|
|
if (_mMeasureObject == nullptr) {
|
|
return;
|
|
}
|
|
if (_mMeasureObject->isRemoving()) {
|
|
return;
|
|
}
|
|
|
|
if (_mViewObject && _mGuiDocument) {
|
|
_mGuiDocument->removeAnnotationViewProvider(_mViewObject->getTypeId().getName());
|
|
_mViewObject = nullptr;
|
|
}
|
|
|
|
delete _mMeasureObject;
|
|
setMeasureObject(nullptr);
|
|
}
|
|
|
|
bool TaskMeasure::hasSelection()
|
|
{
|
|
return !Gui::Selection().getSelection().empty();
|
|
}
|
|
|
|
void TaskMeasure::clearSelection()
|
|
{
|
|
Gui::Selection().clearSelection();
|
|
}
|
|
|
|
void TaskMeasure::onSelectionChanged(const Gui::SelectionChanges& msg)
|
|
{
|
|
// Skip non-relevant events
|
|
if (msg.Type != SelectionChanges::AddSelection && msg.Type != SelectionChanges::RmvSelection
|
|
&& msg.Type != SelectionChanges::SetSelection
|
|
&& msg.Type != SelectionChanges::ClrSelection) {
|
|
|
|
return;
|
|
}
|
|
|
|
update();
|
|
}
|
|
|
|
bool TaskMeasure::eventFilter(QObject* obj, QEvent* event)
|
|
{
|
|
|
|
if (event->type() == QEvent::KeyPress) {
|
|
auto keyEvent = static_cast<QKeyEvent*>(event);
|
|
|
|
if (keyEvent->key() == Qt::Key_Escape) {
|
|
|
|
if (this->hasSelection()) {
|
|
this->reset();
|
|
}
|
|
else {
|
|
this->reject();
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
if (keyEvent->key() == Qt::Key_Return || keyEvent->key() == Qt::Key_Enter) {
|
|
// Save object. Indirectly dependent on whether the apply button is enabled
|
|
// enabled if valid measurement object.
|
|
this->buttonBox->button(QDialogButtonBox::Apply)->click();
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return TaskDialog::eventFilter(obj, event);
|
|
}
|
|
|
|
void TaskMeasure::setDeltaPossible(bool possible)
|
|
{
|
|
showDelta->setVisible(possible);
|
|
showDeltaLabel->setVisible(possible);
|
|
}
|
|
|
|
void TaskMeasure::onModeChanged(int index)
|
|
{
|
|
explicitMode = (index != 0);
|
|
|
|
this->update();
|
|
}
|
|
|
|
void TaskMeasure::showDeltaChanged(int checkState)
|
|
{
|
|
delta = checkState == Qt::CheckState::Checked;
|
|
|
|
QSettings settings;
|
|
settings.beginGroup(QLatin1String(taskMeasureSettingsGroup));
|
|
settings.setValue(QLatin1String(taskMeasureShowDeltaSettingsName), delta);
|
|
|
|
this->update();
|
|
}
|
|
|
|
void TaskMeasure::setModeSilent(App::MeasureType* mode)
|
|
{
|
|
modeSwitch->blockSignals(true);
|
|
|
|
if (mode == nullptr) {
|
|
modeSwitch->setCurrentIndex(0);
|
|
}
|
|
else {
|
|
modeSwitch->setCurrentText(QString::fromLatin1(mode->label.c_str()));
|
|
}
|
|
modeSwitch->blockSignals(false);
|
|
}
|
|
|
|
// Get explicitly set measure type from the mode switch
|
|
App::MeasureType* TaskMeasure::getMeasureType()
|
|
{
|
|
for (App::MeasureType* mType : App::MeasureManager::getMeasureTypes()) {
|
|
if (mType->label.c_str() == modeSwitch->currentText().toLatin1()) {
|
|
return mType;
|
|
}
|
|
}
|
|
return nullptr;
|
|
}
|