7306ed28b0
as reported in https://tracker.freecadweb.org/view.php?id=3818 we treat the blind hole depth not according to the conventions. The size of the drill point due to the angle is normally not taken into account but FC does this in any case. This PR adds therefore an option, that is by default off, to take the drill point size into account. Without the option, (the new default) the depth is calculated according to the conventions. The PR also removes unused widgets and restored the tab order in the .ui file. The thread parameters were never used. In case we made in future the decision to carve into holes real (modeled) threads, we need a special UI for that solution anyway so having the dead code in is not helpful at all.
124 lines
5.1 KiB
Python
124 lines
5.1 KiB
Python
#**************************************************************************
|
|
# Copyright (c) 2017 Kurt Kremitzki <kkremitzki@gmail.com> *
|
|
# *
|
|
# This file is part of the FreeCAD CAx development system. *
|
|
# *
|
|
# This program is free software; you can redistribute it and/or modify *
|
|
# it under the terms of the GNU Lesser General Public License (LGPL) *
|
|
# as published by the Free Software Foundation; either version 2 of *
|
|
# the License, or (at your option) any later version. *
|
|
# for detail see the LICENCE text file. *
|
|
# *
|
|
# FreeCAD is distributed in the hope that it will be useful, *
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of *
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
|
|
# GNU Library General Public License for more details. *
|
|
# *
|
|
# You should have received a copy of the GNU Library General Public *
|
|
# License along with FreeCAD; if not, write to the Free Software *
|
|
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 *
|
|
# USA *
|
|
#**************************************************************************
|
|
from math import pi
|
|
import unittest
|
|
|
|
import FreeCAD
|
|
import TestSketcherApp
|
|
|
|
App = FreeCAD
|
|
|
|
class TestHole(unittest.TestCase):
|
|
def setUp(self):
|
|
self.Doc = FreeCAD.newDocument("PartDesignTestHole")
|
|
self.Body = self.Doc.addObject('PartDesign::Body','Body')
|
|
self.Box = self.Doc.addObject('PartDesign::AdditiveBox','Box')
|
|
self.Box.Length=10
|
|
self.Box.Width=10
|
|
self.Box.Height=10
|
|
self.Body.addObject(self.Box)
|
|
self.Doc.recompute()
|
|
self.HoleSketch = self.Doc.addObject('Sketcher::SketchObject', 'SketchHole')
|
|
self.HoleSketch.Support = (self.Doc.XY_Plane, [''])
|
|
self.HoleSketch.MapMode = 'FlatFace'
|
|
self.HoleSketch.MapReversed = True
|
|
self.Body.addObject(self.HoleSketch)
|
|
TestSketcherApp.CreateCircleSketch(self.HoleSketch, (-5, 5), 1)
|
|
self.Doc.recompute()
|
|
self.Hole = self.Doc.addObject("PartDesign::Hole", "Hole")
|
|
self.Hole.Profile = self.HoleSketch
|
|
self.Body.addObject(self.Hole)
|
|
self.Doc.recompute()
|
|
|
|
def testPlainHole(self):
|
|
self.Hole.Diameter = 6
|
|
self.Hole.Depth = 10
|
|
# self.Hole.DrillPointAngle = 118.000000
|
|
# self.Hole.TaperedAngle = 90
|
|
self.Hole.ThreadType = 0
|
|
self.Hole.HoleCutType = 0 # 1 = Counterbore, 2 = Countersink
|
|
# self.Hole.HoleCutDiameter = 5
|
|
# self.Hole.HoleCutCountersinkAngle = 90
|
|
# self.Hole.HoleCutDepth = 2 # Counterbore
|
|
self.Hole.DepthType = 0 # 1 = Through all
|
|
self.Hole.DrillPoint = 0 # 1 = Angled
|
|
self.Hole.Tapered = 0 # On/off
|
|
self.Doc.recompute()
|
|
self.assertAlmostEqual(self.Hole.Shape.Volume, 10**3 - pi * 3**2 * 10)
|
|
|
|
def testTaperedHole(self):
|
|
self.Hole.Diameter = 6
|
|
self.Hole.Depth = 5
|
|
self.Hole.TaperedAngle = 60
|
|
self.Hole.ThreadType = 0
|
|
self.Hole.HoleCutType = 0
|
|
self.Hole.DepthType = 0
|
|
self.Hole.DrillPoint = 0
|
|
self.Hole.Tapered = 1
|
|
self.Doc.recompute()
|
|
self.assertEqual(len(self.Hole.Shape.Faces), 8)
|
|
|
|
def testAngledDrillHole(self):
|
|
self.Hole.Diameter = 6
|
|
self.Hole.Depth = 10
|
|
self.Hole.DrillPointAngle = 118
|
|
self.Hole.ThreadType = 0
|
|
self.Hole.HoleCutType = 0
|
|
self.Hole.DepthType = 0
|
|
self.Hole.DrillPoint = 1
|
|
self.Hole.Tapered = 0
|
|
self.Hole.DrillForDepth = 1
|
|
self.Doc.recompute()
|
|
self.assertEqual(len(self.Hole.Shape.Faces), 8)
|
|
|
|
def testCounterboreHole(self):
|
|
self.Hole.Diameter = 6
|
|
self.Hole.Depth = 10
|
|
self.Hole.ThreadType = 0
|
|
self.Hole.HoleCutType = 1
|
|
self.Hole.HoleCutDiameter = 8
|
|
self.Hole.HoleCutDepth = 5
|
|
self.Hole.DepthType = 0
|
|
self.Hole.DrillPoint = 0
|
|
self.Hole.Tapered = 0
|
|
self.Doc.recompute()
|
|
self.assertAlmostEqual(self.Hole.Shape.Volume, 10**3 - pi * 3**2 * 5 - pi * 4**2 * 5)
|
|
|
|
def testCountersinkHole(self):
|
|
self.Hole.Diameter = 6
|
|
self.Hole.Depth = 10
|
|
self.Hole.ThreadType = 0
|
|
self.Hole.HoleCutType = 2
|
|
self.Hole.HoleCutDiameter = 9
|
|
self.Hole.HoleCutCountersinkAngle = 90
|
|
self.Hole.DepthType = 0
|
|
self.Hole.DrillPoint = 0
|
|
self.Hole.Tapered = 0
|
|
self.Doc.recompute()
|
|
self.assertAlmostEqual(self.Hole.Shape.Volume, 10**3 - pi * 3**2 * 10 - 24.7400421)
|
|
|
|
def tearDown(self):
|
|
#closing doc
|
|
FreeCAD.closeDocument("PartDesignTestHole")
|
|
#print ("omit closing document for debugging")
|
|
|