Files
create/src/Gui/ViewProviderDatum.h
wmayer ce55d6be75 Gui: Rename ViewProviderDatum::getRoot() to ViewProviderDatum::getDatumRoot()
Before the change the compiler raised the warning: 'Gui::ViewProviderDatum::getRoot' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
In the base class the method getRoot() is declared as const while in ViewProviderDatum it's not and that's why it's considered as an overloaded method.
However, this signature causes two problems:
1. In the client code it's not always clear which version of getRoot() should be called
2. It violates const-correctness

So, trying to declare the method ViewProviderDatum::getRoot() as const it now overrides the method of the base class (and fixes the warning) but
this doesn't lead to the expected result: See https://forum.freecad.org/viewtopic.php?p=796064#p796064

The other option is to rename the method. And this gives the expected result now.
2024-12-10 12:49:42 +01:00

79 lines
3.0 KiB
C++

/***************************************************************************
* Copyright (c) 2015 Alexander Golubev (Fat-Zer) <fatzer2@gmail.com> *
* *
* This file is part of the FreeCAD CAx development system. *
* *
* This library is free software; you can redistribute it and/or *
* modify it under the terms of the GNU Library General Public *
* License as published by the Free Software Foundation; either *
* version 2 of the License, or (at your option) any later version. *
* *
* This library is distributed in the hope that it will be useful, *
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
* GNU Library General Public License for more details. *
* *
* You should have received a copy of the GNU Library General Public *
* License along with this library; see the file COPYING.LIB. If not, *
* write to the Free Software Foundation, Inc., 59 Temple Place, *
* Suite 330, Boston, MA 02111-1307, USA *
* *
***************************************************************************/
#ifndef VIEWPROVIDEDATUM_H_BYJRZNDL
#define VIEWPROVIDEDATUM_H_BYJRZNDL
#include "ViewProviderGeometryObject.h"
class SoText2;
class SoScale;
namespace Gui
{
class SoShapeScale;
/**
* View provider associated with an App::DatumElement.
*/
class GuiExport ViewProviderDatum : public ViewProviderGeometryObject {
PROPERTY_HEADER_WITH_OVERRIDE(Gui::ViewProviderDatum);
public:
ViewProviderDatum();
~ViewProviderDatum() override;
/// Get point derived classes will add their specific stuff
SoSeparator* getDatumRoot() const { return pRoot; }
/// Get pointer to the text label associated with the feature
SoText2* getLabel() const { return pLabel; }
void attach(App::DocumentObject*) override;
std::vector<std::string> getDisplayModes() const override;
void setDisplayMode(const char* ModeName) override;
/// @name Suppress ViewProviderGeometryObject's behaviour
///@{
bool setEdit(int) override
{
return false;
}
void unsetEdit(int) override
{ }
///@}
protected:
void onChanged(const App::Property* prop) override;
bool onDelete(const std::vector<std::string>&) override;
protected:
SoSeparator* pRoot;
SoShapeScale* soScale;
SoText2* pLabel;
double lineThickness;
};
} /* Gui */
#endif /* end of include guard: VIEWPROVIDEDATUM_H_BYJRZNDL */