Files
create/src/Mod
paul f3910b386a [DraftBind] Bug-fix Consecutive Face Touch at Corner (#15350)
* [DraftBind] Bug-fix Consecutive Face Touch at Corner

Bug-fix Consecutive face (Wall segment) touch at corner.

Forum Discussion :  https://forum.freecad.org/viewtopic.php?p=769213#p769213

* [DraftBind] Bug-fix Consecutive Face Touch at Corner


Update following commit at https://github.com/FreeCAD/FreeCAD/pull/15350

* Minor formatting changes

coding_conventions.md says variable_names_without_capitals

* Use areColinear to find problematic edge pairs

It is clearer to use `areColinear` instead of `findIntersection` to detect problematic edge pairs.

@paullee0 Please check. Thanks.

* Use Shape.section() to find touching edges

Using `areColinear` indeed does not work here.

But the `findIntersection` function is very confusing IMO. It finds intersections for collinear edges which does not make sense.

Let's use `Shape.section()` instead.

Also improved the 'ascii art' a little.

* typo

* Some minor improvements.

* [DraftBind] Bug-fix Consecutive Face Touch at Corner

Update handling closed wire(s) case

* Typo

* [DraftBind] Bug-fix Consecutive Face Touch at Corner

Further update handling closed wire(s) case :

# if wires are closed, 1st & last series of faces might be connected
# except when
# 1) there are only 2 series, connecting would return invalid shape
# 2) 1st series of faces happens to be [], i.e. 1st edge pairs touch

---------

Co-authored-by: Roy-043 <info@b-k-g.nl>
2024-08-08 11:08:59 +02:00
..
2024-08-05 10:42:18 -05:00
2024-08-05 11:09:45 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-07-16 11:48:07 +02:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:49:14 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00
2024-08-05 10:42:18 -05:00