From 9bb4c72dd3877c8c43308c53917068173c3907df Mon Sep 17 00:00:00 2001 From: lorenz Date: Fri, 17 Jul 2020 08:15:57 +0200 Subject: [PATCH 1/4] Update README.md --- README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index b711288..06eaf1c 100644 --- a/README.md +++ b/README.md @@ -28,6 +28,13 @@ __python > 3 (for python2 use branch py2)__ ### Crown-Gear +### Worm-Gear + +### Timing-Gear + +### Latern-Gear +![latern-gear](examples/latern-gear.png) + --------------------------- ## Installation From f89214dad47ec6566dd81e9a0a539f10a2b0bb0e Mon Sep 17 00:00:00 2001 From: lorenz Date: Fri, 17 Jul 2020 10:46:40 +0200 Subject: [PATCH 2/4] remove unused variables --- freecad/gears/features.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/freecad/gears/features.py b/freecad/gears/features.py index 49450b8..5eacc5c 100644 --- a/freecad/gears/features.py +++ b/freecad/gears/features.py @@ -810,12 +810,9 @@ class TimingGear(object): m_34 = (r5 - r_34) * np.array([-np.sin(phi4), np.cos(phi4)]) - - x1 = np.array([0., r5 - h]) x2 = np.array([-r_12 * np.sin(phi_12), m_12[1] - r_12 * np.cos(phi_12)]) x3 = m_34 + r_34 / (r_34 + r_23) * (m_23 - m_34) x4 = r4 * np.array([-np.sin(phi4), np.cos(phi4)]) - x5 = r5 * np.array([-np.sin(phi5), np.cos(phi5)]) ref = reflection(-phi5 - np.pi / 2) @@ -980,4 +977,4 @@ def makeBSplineWire(pts): def on_mirror_plane(face, z, direction, small_size=0.000001): # the tolerance is very high. Maybe there is a bug in Part.makeHelix. return (face.normalAt(0, 0).cross(direction).Length < small_size and - abs(face.CenterOfMass.z - z) < small_size) \ No newline at end of file + abs(face.CenterOfMass.z - z) < small_size) From ee96e6efa96157dc7a251b22e6b0594579ca6a2c Mon Sep 17 00:00:00 2001 From: lorenz Date: Fri, 17 Jul 2020 10:47:34 +0200 Subject: [PATCH 3/4] remove screenshots --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index 06eaf1c..f64e5e1 100644 --- a/README.md +++ b/README.md @@ -5,9 +5,6 @@ FreeCAD > v0.16 __python > 3 (for python2 use branch py2)__ -## Screenshots -![gear](examples/spiral.png) -![gear1](examples/animated_spiral.gif) ## Supported gear-types From 83cbc800fd1bc432a83d916e3679c51bc4226847 Mon Sep 17 00:00:00 2001 From: lorenz Date: Fri, 17 Jul 2020 10:51:27 +0200 Subject: [PATCH 4/4] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index f64e5e1..da91415 100644 --- a/README.md +++ b/README.md @@ -83,4 +83,4 @@ by browsing this repositories [issue queue](https://github.com/looooo/freecad.ge * "FC Gears: Feedback thread" ([thread](https://forum.freecadweb.org/viewtopic.php?f=8&t=27626)) # License -GNU General Public License v2.0 +GNU General Public License v3.0