From dcf5edd4f03d6639d90529d09ec56bd2ea734c61 Mon Sep 17 00:00:00 2001 From: looooo Date: Thu, 4 Jan 2024 20:10:31 +0100 Subject: [PATCH] helicalextrusion -> helical_extrusion --- freecad/gears/basegear.py | 2 +- freecad/gears/cycloidgear.py | 4 ++-- freecad/gears/internalinvolutegear.py | 4 ++-- freecad/gears/involutegear.py | 4 ++-- freecad/gears/wormgear.py | 4 ++-- tests/tests.py | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/freecad/gears/basegear.py b/freecad/gears/basegear.py index f36a880..9c02174 100644 --- a/freecad/gears/basegear.py +++ b/freecad/gears/basegear.py @@ -151,7 +151,7 @@ def part_arc_from_points_and_center(p_1, p_2, m): ) -def helicalextrusion(face, height, angle, double_helix=False): +def helical_extrusion(face, height, angle, double_helix=False): """ A helical extrusion using the BRepOffsetAPI face -- the face to extrude (may contain holes, i.e. more then one wires) diff --git a/freecad/gears/cycloidgear.py b/freecad/gears/cycloidgear.py index bd21d5d..39f0c6f 100644 --- a/freecad/gears/cycloidgear.py +++ b/freecad/gears/cycloidgear.py @@ -27,7 +27,7 @@ from .basegear import ( BaseGear, points_to_wire, insert_fillet, - helicalextrusion, + helical_extrusion, rotate_tooth, ) @@ -190,4 +190,4 @@ class CycloidGear(BaseGear): twist_angle = ( fp.height.Value * np.tan(fp.beta.Value * np.pi / 180) * 2 / fp.gear.d ) - return helicalextrusion(base, fp.height.Value, twist_angle, fp.double_helix) + return helical_extrusion(base, fp.height.Value, twist_angle, fp.double_helix) diff --git a/freecad/gears/internalinvolutegear.py b/freecad/gears/internalinvolutegear.py index 452bff6..2ec3ed0 100644 --- a/freecad/gears/internalinvolutegear.py +++ b/freecad/gears/internalinvolutegear.py @@ -28,7 +28,7 @@ from .basegear import ( BaseGear, points_to_wire, insert_fillet, - helicalextrusion, + helical_extrusion, rotate_tooth, ) @@ -239,7 +239,7 @@ class InternalInvoluteGear(BaseGear): return base.extrude(app.Vector(0, 0, fp.height.Value)) else: twist_angle = fp.height.Value * np.tan(fp.gear.beta) * 2 / fp.gear.d - return helicalextrusion( + return helical_extrusion( base, fp.height.Value, twist_angle, fp.double_helix ) else: diff --git a/freecad/gears/involutegear.py b/freecad/gears/involutegear.py index fe31488..6457839 100644 --- a/freecad/gears/involutegear.py +++ b/freecad/gears/involutegear.py @@ -28,7 +28,7 @@ from .basegear import ( BaseGear, points_to_wire, insert_fillet, - helicalextrusion, + helical_extrusion, rotate_tooth, ) @@ -257,7 +257,7 @@ class InvoluteGear(BaseGear): return base.extrude(app.Vector(0, 0, obj.height.Value)) else: twist_angle = obj.height.Value * np.tan(obj.gear.beta) * 2 / obj.gear.d - return helicalextrusion( + return helical_extrusion( base, obj.height.Value, twist_angle, obj.double_helix ) else: diff --git a/freecad/gears/wormgear.py b/freecad/gears/wormgear.py index 3c9ac1f..40ae5ff 100644 --- a/freecad/gears/wormgear.py +++ b/freecad/gears/wormgear.py @@ -24,7 +24,7 @@ from freecad import part from pygears.involute_tooth import InvoluteTooth from pygears._functions import rotation -from .basegear import BaseGear, helicalextrusion, fcvec +from .basegear import BaseGear, helical_extrusion, fcvec class WormGear(BaseGear): @@ -148,5 +148,5 @@ class WormGear(BaseGear): if h == 0: return full_wire else: - shape = helicalextrusion(part.Face(full_wire), h, h * np.tan(beta) * 2 / d) + shape = helical_extrusion(part.Face(full_wire), h, h * np.tan(beta) * 2 / d) return shape diff --git a/tests/tests.py b/tests/tests.py index 8f49d31..debcbf7 100644 --- a/tests/tests.py +++ b/tests/tests.py @@ -2,7 +2,7 @@ import unittest from freecad import app from freecad import part -from freecad.gears.basegear import helicalextrusion +from freecad.gears.basegear import helical_extrusion @@ -17,7 +17,7 @@ class GearTests(unittest.TestCase): a = part.Circle(m, n, r) face = part.Face(part.Wire(a.toShape())) - s = helicalextrusion(face, h, 1) + s = helical_extrusion(face, h, 1) # face 0 is the cylinder # face 1 is pointing in positive z direction