fix: revoke_token() bypasses _request() -- inconsistent error handling #12

New Issue

forbes · 2026-02-16T15:56:15Z

forbes commented

2026-02-16 15:56:15 +00:00

Problem

revoke_token() at silo_client/__init__.py:393-403 manually builds an HTTP request instead of using the shared _request() helper:

def revoke_token(self, token_id: str) -> None:
    url = f"{self.base_url}/auth/tokens/{token_id}"
    headers = {"Content-Type": "application/json"}
    headers.update(self._auth_headers())
    req = urllib.request.Request(url, headers=headers, method="DELETE")
    try:
        urllib.request.urlopen(req, context=self._ssl_context())
    except urllib.error.HTTPError as e:
        raise RuntimeError(f"API error {e.code}: {e.read().decode()}")
    except urllib.error.URLError as e:
        raise RuntimeError(f"Connection error: {e.reason}")

This means it does not clear auth on 401 responses (which _request() does).

Fix

Replace with:

def revoke_token(self, token_id: str) -> None:
    self._request("DELETE", f"/auth/tokens/{token_id}", raw=True)

This is the same pattern already applied to delete_bom_entry() in commit 68a4139.

References

Commit 68a4139: fix: use _request() in delete_bom_entry() for consistent error handling

## Problem `revoke_token()` at `silo_client/__init__.py:393-403` manually builds an HTTP request instead of using the shared `_request()` helper: ```python def revoke_token(self, token_id: str) -> None: url = f"{self.base_url}/auth/tokens/{token_id}" headers = {"Content-Type": "application/json"} headers.update(self._auth_headers()) req = urllib.request.Request(url, headers=headers, method="DELETE") try: urllib.request.urlopen(req, context=self._ssl_context()) except urllib.error.HTTPError as e: raise RuntimeError(f"API error {e.code}: {e.read().decode()}") except urllib.error.URLError as e: raise RuntimeError(f"Connection error: {e.reason}") ``` This means it does **not** clear auth on 401 responses (which `_request()` does). ## Fix Replace with: ```python def revoke_token(self, token_id: str) -> None: self._request("DELETE", f"/auth/tokens/{token_id}", raw=True) ``` This is the same pattern already applied to `delete_bom_entry()` in commit `68a4139`. ## References - Commit 68a4139: fix: use _request() in delete_bom_entry() for consistent error handling

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kindred/silo-client#12