fix(silo): fix auth crashes, menu redundancy, and origin connect #1

forbes · 2026-02-07T20:31:09Z

forbes commented

2026-02-07 20:31:09 +00:00

Fixes

Critical: Missing/wrong function calls causing crashes

_get_auth_token() was called but never defined — caused NameError when opening Settings dialog
_client.auth_username(), .auth_role(), .auth_source() were called in the auth dock widget's _refresh_status() but these methods don't exist on SiloClient — caused AttributeError at startup, preventing the auth dock widget from ever appearing
Replaced with existing _get_auth_username(), _get_auth_role(), _get_auth_source() helper functions

Origin connect() fix

silo_origin.py connect() was using non-existent FreeCADGui.Command.get() API and calling Silo_Auth which only shows the dock panel (not the login dialog)
Now directly invokes the login dialog via the auth dock widget

Toolbar and Silo menu had identical commands; now toolbar has file operations, menu has admin/management commands (Info, BOM, Tag Projects, Set Status, Rollback, Settings, Auth)

Cleanup

Removed DEBUG logging from Silo_Save command

## Fixes ### Critical: Missing/wrong function calls causing crashes - **`_get_auth_token()`** was called but never defined — caused `NameError` when opening Settings dialog - **`_client.auth_username()`, `.auth_role()`, `.auth_source()`** were called in the auth dock widget's `_refresh_status()` but these methods don't exist on `SiloClient` — caused `AttributeError` at startup, preventing the auth dock widget from ever appearing - Replaced with existing `_get_auth_username()`, `_get_auth_role()`, `_get_auth_source()` helper functions ### Origin connect() fix - `silo_origin.py connect()` was using non-existent `FreeCADGui.Command.get()` API and calling `Silo_Auth` which only shows the dock panel (not the login dialog) - Now directly invokes the login dialog via the auth dock widget ### Menu redundancy - Toolbar and Silo menu had identical commands; now toolbar has file operations, menu has admin/management commands (Info, BOM, Tag Projects, Set Status, Rollback, Settings, Auth) ### Cleanup - Removed DEBUG logging from Silo_Save command

forbes added 1 commit 2026-02-07 20:31:10 +00:00

fix(silo): fix auth crashes, menu redundancy, and origin connect 02ad9a00db

- Add missing _get_auth_token() function that caused NameError in Settings
- Replace _client.auth_username/role/source() calls with _get_auth_*()
  helpers (methods don't exist on SiloClient, crashed auth dock widget)
- Fix connect() in silo_origin.py to show login dialog instead of just
  revealing the dock panel (was using non-existent Command.get() API)
- Separate toolbar (file ops) from menu (admin/management commands)
- Remove DEBUG logging from Silo_Save command
- Fix long line formatting in silo_origin.py

forbes merged commit 3228ef5f79 into main

2026-02-07 20:33:26 +00:00

forbes referenced this issue from a commit

2026-02-07 20:33:27 +00:00

Merge pull request 'fix(silo): fix auth crashes, menu redundancy, and origin connect' (#1) from fix/silo-workbench-bugs into main

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kindred/silo-mod#1