kindred/silo-mod
1
1
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use FreeCADGui.Document.Modified instead of App.Document.IsModified() #16

Merged
forbes merged 2 commits from fix/pull-is-modified-bug into main 2026-02-10 16:41:24 +00:00
Conversation 0 Commits 2 Files Changed 1 +4 -2
forbes commented 2026-02-10 16:41:10 +00:00
Owner
Copy Link

App.Document has no IsModified() method, causing Silo_Pull to crash with
AttributeError. The correct API is to get the Gui document and check its
Modified property, consistent with the pattern used elsewhere in this file
(lines 891, 913).

App.Document has no IsModified() method, causing Silo_Pull to crash with AttributeError. The correct API is to get the Gui document and check its Modified property, consistent with the pattern used elsewhere in this file (lines 891, 913).
forbes added 1 commit 2026-02-10 16:41:11 +00:00
fix: use FreeCADGui.Document.Modified instead of App.Document.IsModified() 6c9789fdf3 
App.Document has no IsModified() method, causing Silo_Pull to crash with
AttributeError. The correct API is to get the Gui document and check its
Modified property, consistent with the pattern used elsewhere in this file
(lines 891, 913).
forbes added 1 commit 2026-02-10 16:41:17 +00:00
Merge branch 'main' into fix/pull-is-modified-bug de80e392f5
forbes merged commit 32d5f1ea1b into main 2026-02-10 16:41:24 +00:00
forbes deleted branch fix/pull-is-modified-bug 2026-02-10 16:41:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 debugging
Debugging and diagnostics
 enhancement
New feature or request
 priority:high
High priority
 ui
User interface
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/silo-mod#16
Delete Branch "fix/pull-is-modified-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?