kindred/silo-mod
1
1
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

Add commit comments and open-from-activity to Database Activity pane #9

New Issue
Closed
opened 2026-02-08 22:09:01 +00:00 by forbes · 0 comments
forbes commented 2026-02-08 22:09:01 +00:00
Owner
Copy Link

Labels: enhancement, ui

The Database Activity pane currently displays a flat list of items with part number, description, and date. It's read-only with no interaction beyond selection highlighting.

Current state

Each row shows: {part_number} – {description} – {date}

No way to:

  • See what changed in each activity entry
  • Open the item directly from the pane
  • Add or view revision comments

Proposed changes

1. Show revision comment inline

Each activity entry should display the most recent revision's comment field (already tracked in the revisions table per spec). If no comment exists, show (no comment) in muted text.

A01-0002 – FILAMENT WINDING UNIT ASSY – 2026-01-29
  "Added tensioner mounting holes"

A03-0001 – 3DX15 CONTROLS SASSY – 2026-01-29
  (no comment)

This requires fetching revision data alongside items. Options:

  • Extend the existing items list query to include latest revision comment (server-side join, preferred)
  • Or fetch GET /api/items/{partNumber}/revisions?limit=1 per item (chatty, avoid)

Server-side suggestion: If GET /api/items doesn't already return latest_comment, consider adding it as an optional field via query param ?include=latest_comment to keep the default response lean.

2. Editable comment on commit

When the user performs Silo_Commit, the commit dialog should include a comment field (single-line or small multiline). This maps directly to the comment column on the revisions table — the API endpoint POST /api/items/{partNumber}/revisions already accepts a comment field per spec.

If the user leaves the comment blank, the revision is created with comment: null (current behavior preserved).

3. Open item from activity pane

Each activity row should support:

  • Double-click → Run Silo_Checkout for that part number (download from MinIO and open in Create)
  • Right-click context menu with:
    • Open in Create — checkout and open
    • Open in Browser — launch https://silo.kindred.internal/items/{partNumber} in default browser (web UI detail view)
    • Copy Part Number — copy to clipboard
    • View Revisions — run Silo_Log for that part number

4. Visual tweaks

  • Highlight items that are already checked out locally (match against local SiloPartNumber properties)
  • Show revision number alongside date: A01-0002 – FILAMENT WINDING UNIT ASSY – Rev 3 – 2026-01-29
  • Truncate long descriptions with ellipsis, full text in tooltip

Wireframe

Database Activity
┌─────────────────────────────────────────────────────────────┐
│ A01-0002 – FILAMENT WINDING UNIT ASSY – Rev 3 – 2026-01-29 │  ● local
│   "Added tensioner mounting holes"                          │
│ A01-0003 – 3DX10 EXTRUDER LINE – Rev 1 – 2026-02-01       │
│   (no comment)                                              │
│ A03-0001 – 3DX15 CONTROLS SASSY – Rev 2 – 2026-01-29      │  ● local
│   "Initial BOM complete"                                    │
│ A04-0001 – HOUSED AIR PULLEY HALF ROUND – Rev 1 – 2026-01… │
│   (no comment)                                              │
└─────────────────────────────────────────────────────────────┘
                                        [right-click]
                                        ┌─────────────────────┐
                                        │ Open in Create     │
                                        │ Open in Browser     │
                                        │ Copy Part Number    │
                                        │ View Revisions      │
                                        └─────────────────────┘

Acceptance criteria

  • Activity entries show latest revision comment (or muted placeholder if none)
  • Activity entries show revision number
  • Silo_Commit dialog includes a comment text field
  • Double-click on activity row triggers checkout/open
  • Right-click context menu with Open/Browser/Copy/Revisions actions
  • Items checked out locally marked with a visual indicator
  • Long descriptions truncated with tooltip
  • Server-side: GET /api/items supports ?include=latest_comment (or equivalent) to avoid N+1 queries — file as sub-issue on [silo] if needed
**Labels:** `enhancement`, `ui` The Database Activity pane currently displays a flat list of items with part number, description, and date. It's read-only with no interaction beyond selection highlighting. ## Current state Each row shows: `{part_number} – {description} – {date}` No way to: - See *what changed* in each activity entry - Open the item directly from the pane - Add or view revision comments ## Proposed changes ### 1. Show revision comment inline Each activity entry should display the most recent revision's `comment` field (already tracked in the `revisions` table per spec). If no comment exists, show `(no comment)` in muted text. ``` A01-0002 – FILAMENT WINDING UNIT ASSY – 2026-01-29 "Added tensioner mounting holes" A03-0001 – 3DX15 CONTROLS SASSY – 2026-01-29 (no comment) ``` This requires fetching revision data alongside items. Options: - Extend the existing items list query to include latest revision comment (server-side join, preferred) - Or fetch `GET /api/items/{partNumber}/revisions?limit=1` per item (chatty, avoid) **Server-side suggestion:** If `GET /api/items` doesn't already return `latest_comment`, consider adding it as an optional field via query param `?include=latest_comment` to keep the default response lean. ### 2. Editable comment on commit When the user performs `Silo_Commit`, the commit dialog should include a comment field (single-line or small multiline). This maps directly to the `comment` column on the `revisions` table — the API endpoint `POST /api/items/{partNumber}/revisions` already accepts a `comment` field per spec. If the user leaves the comment blank, the revision is created with `comment: null` (current behavior preserved). ### 3. Open item from activity pane Each activity row should support: - **Double-click** → Run `Silo_Checkout` for that part number (download from MinIO and open in Create) - **Right-click context menu** with: - `Open in Create` — checkout and open - `Open in Browser` — launch `https://silo.kindred.internal/items/{partNumber}` in default browser (web UI detail view) - `Copy Part Number` — copy to clipboard - `View Revisions` — run `Silo_Log` for that part number ### 4. Visual tweaks - Highlight items that are already checked out locally (match against local `SiloPartNumber` properties) - Show revision number alongside date: `A01-0002 – FILAMENT WINDING UNIT ASSY – Rev 3 – 2026-01-29` - Truncate long descriptions with ellipsis, full text in tooltip ## Wireframe ``` Database Activity ┌─────────────────────────────────────────────────────────────┐ │ A01-0002 – FILAMENT WINDING UNIT ASSY – Rev 3 – 2026-01-29 │ ● local │ "Added tensioner mounting holes" │ │ A01-0003 – 3DX10 EXTRUDER LINE – Rev 1 – 2026-02-01 │ │ (no comment) │ │ A03-0001 – 3DX15 CONTROLS SASSY – Rev 2 – 2026-01-29 │ ● local │ "Initial BOM complete" │ │ A04-0001 – HOUSED AIR PULLEY HALF ROUND – Rev 1 – 2026-01… │ │ (no comment) │ └─────────────────────────────────────────────────────────────┘ [right-click] ┌─────────────────────┐ │ Open in Create │ │ Open in Browser │ │ Copy Part Number │ │ View Revisions │ └─────────────────────┘ ``` ## Acceptance criteria - [ ] Activity entries show latest revision comment (or muted placeholder if none) - [ ] Activity entries show revision number - [ ] `Silo_Commit` dialog includes a comment text field - [ ] Double-click on activity row triggers checkout/open - [ ] Right-click context menu with Open/Browser/Copy/Revisions actions - [ ] Items checked out locally marked with a visual indicator - [ ] Long descriptions truncated with tooltip - [ ] Server-side: `GET /api/items` supports `?include=latest_comment` (or equivalent) to avoid N+1 queries — file as sub-issue on `[silo]` if needed
forbes added the enhancementui labels 2026-02-08 22:09:01 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 debugging
Debugging and diagnostics
 enhancement
New feature or request
 priority:high
High priority
 ui
User interface
No Label enhancement ui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/silo-mod#9
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?