kindred/silo
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request 'fix(sse): disable read deadline for long-lived connections' (#56) from fix-sse-read-deadline into main

Browse Source 
Reviewed-on: #56
This commit was merged in pull request #56.
This commit is contained in:
forbes
2026-02-09 17:39:09 +00:00
parent 2157b40d06 f7aa673d2c
commit 701a5c21ce
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
internal/api/sse_handler.go
View File

@@ -16,9 +16,12 @@ func (s *Server) HandleEvents(w http.ResponseWriter, r *http.Request) {
return return
} }
// Disable the write deadline for this long-lived connection. // Disable read and write deadlines for this long-lived connection.
// The server's WriteTimeout (15s) would otherwise kill it. // The server's ReadTimeout/WriteTimeout (15s) would otherwise kill it.
rc := http.NewResponseController(w) rc := http.NewResponseController(w)
if err := rc.SetReadDeadline(time.Time{}); err != nil {
s.logger.Warn().Err(err).Msg("failed to disable read deadline for SSE")
}
if err := rc.SetWriteDeadline(time.Time{}); err != nil { if err := rc.SetWriteDeadline(time.Time{}); err != nil {
s.logger.Warn().Err(err).Msg("failed to disable write deadline for SSE") s.logger.Warn().Err(err).Msg("failed to disable write deadline for SSE")
} }