WIP: fixes mac errors and warnings (#34)

* fixes mac errors and warnings; check on TODO items

* renamed function as override was not of virtual

* removed another using

* experimental adjustment

* move fcDot to public

* renaming things
This commit is contained in:
John Dupuy
2023-11-21 09:16:25 -06:00
committed by GitHub
parent 6f4fca7efb
commit 3952f45945
41 changed files with 137 additions and 146 deletions

View File

@@ -47,21 +47,6 @@ namespace MbD {
return answer;
}
// TODO: can't get the following to work, but CLion says the routine that calls it in FullMatrixFullMatrixDouble is also
// never called.
// template<>
// FRowsptr<std::shared_ptr<FullMatrixDouble>> FullRow<std::shared_ptr<FullMatrixDouble>>::timesTransposeFullMatrixForFMFMDsptr(
// std::shared_ptr<FullMatrixFullMatrixDouble> fullMat)
// {
// //"a*bT = a(1,j)b(k,j)"
// int ncol = fullMat->nrow();
// auto answer = std::make_shared<FullRow<std::shared_ptr<FullMatrixDouble>>>(ncol);
// for (int k = 0; k < ncol; k++) {
// answer->at(k) = this->dot(fullMat->at(k));
// }
// return answer;
// }
template<>
FRowsptr<double> FullRow<double>::timesFullMatrix(std::shared_ptr<FullMatrixDouble> fullMat)
{