kindred/solver
1
0
Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Port shared types to solver/datagen/types.py #1

New Issue
Closed
opened 2026-02-02 19:31:49 +00:00 by forbes · 0 comments
forbes commented 2026-02-02 19:31:49 +00:00
Owner
Copy Link

Summary

Move shared data types from data/synthetic/pebble-game.py into solver/datagen/types.py.

Classes to port

  • JointType enum (L42-63) — CAD joint types with DOF-removal counts
  • RigidBody dataclass (L72-81) — body with position, orientation, local anchors
  • Joint dataclass (L85-99) — joint connecting two bodies with type, anchors, axis, pitch
  • PebbleState dataclass (L103-122) — pebble game internal state tracking
  • ConstraintAnalysis dataclass (L911-930) — combined analysis results

Requirements

  • Full type annotations on all fields
  • Preserve existing docstrings, clean up where needed
  • __all__ export list
  • No functional changes — pure data structures only
  • Imports: numpy, enum, dataclasses, typing

Notes

PebbleState is internal to the pebble game but including it here avoids circular imports. ConstraintAnalysis is the public-facing result type used by both the pebble game analysis and training data generation.

## Summary Move shared data types from `data/synthetic/pebble-game.py` into `solver/datagen/types.py`. ## Classes to port - `JointType` enum (L42-63) — CAD joint types with DOF-removal counts - `RigidBody` dataclass (L72-81) — body with position, orientation, local anchors - `Joint` dataclass (L85-99) — joint connecting two bodies with type, anchors, axis, pitch - `PebbleState` dataclass (L103-122) — pebble game internal state tracking - `ConstraintAnalysis` dataclass (L911-930) — combined analysis results ## Requirements - [ ] Full type annotations on all fields - [ ] Preserve existing docstrings, clean up where needed - [ ] `__all__` export list - [ ] No functional changes — pure data structures only - [ ] Imports: `numpy`, `enum`, `dataclasses`, `typing` ## Notes `PebbleState` is internal to the pebble game but including it here avoids circular imports. `ConstraintAnalysis` is the public-facing result type used by both the pebble game analysis and training data generation.
forbes added the phase:1port labels 2026-02-02 19:31:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
feature
New feature or enhancement
 phase:1
Phase 1: Synthetic Data Generation
 port
Porting existing code into repository
 testing
Tests and test infrastructure
No Label phase:1 port
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/solver#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?