fix(solver): build weight vector after pre-passes to match free param count #35

forbes · 2026-02-23T03:06:33Z

forbes commented

2026-02-23 03:06:33 +00:00

Problem

The weight vector was built before substitution_pass and single_equation_pass, which can fix variables and reduce the free parameter count. This caused a shape mismatch in newton_solve when the Jacobian (built from the reduced free params) had fewer columns than the weight vector had entries:

ValueError: operands could not be broadcast together with shapes (55,27) (1,28)

The broadcast happens at newton.py:103:

J_scaled = J * w_inv_sqrt[np.newaxis, :]

Fix

Move build_weight_vector() after both pre-passes in both the solve and drag paths, so its length matches the actual free parameters used by the Jacobian.

## Problem The weight vector was built before `substitution_pass` and `single_equation_pass`, which can fix variables and reduce the free parameter count. This caused a shape mismatch in `newton_solve` when the Jacobian (built from the reduced free params) had fewer columns than the weight vector had entries: ``` ValueError: operands could not be broadcast together with shapes (55,27) (1,28) ``` The broadcast happens at `newton.py:103`: ```python J_scaled = J * w_inv_sqrt[np.newaxis, :] ``` ## Fix Move `build_weight_vector()` after both pre-passes in both the solve and drag paths, so its length matches the actual free parameters used by the Jacobian.

forbes added 1 commit 2026-02-23 03:06:34 +00:00

fix(solver): build weight vector after pre-passes to match free param count 0825578778

The weight vector was built before substitution_pass and
single_equation_pass, which can fix variables and reduce the free
parameter count. This caused a shape mismatch in newton_solve when
the Jacobian had fewer columns than the weight vector had entries:

  ValueError: operands could not be broadcast together with shapes
  (55,27) (1,28)

Move build_weight_vector() after both pre-passes so its length
matches the actual free parameters used by the Jacobian.

forbes merged commit e7e4266f3d into main

2026-02-23 03:19:28 +00:00

forbes referenced this issue from a commit

2026-02-23 03:19:31 +00:00

Merge pull request 'fix(solver): build weight vector after pre-passes to match free param count' (#35) from fix/weight-vector-after-prepass into main

forbes deleted branch fix/weight-vector-after-prepass

2026-02-23 03:19:31 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kindred/solver#35