kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Maintain backlinks on dynamic property removal. fixes #0003189

Browse Source
This commit is contained in:
Stefan Tröger
2017-09-16 12:11:46 +02:00
committed by wmayer
parent 14a2b0c6c3
commit 00e7c0f2cb
1 changed files with 53 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
src/App/PropertyLinks.cpp
View File

@@ -67,7 +67,21 @@ PropertyLink::PropertyLink()
PropertyLink::~PropertyLink()
{
//in case this property gets dynamically removed
#ifndef USE_OLD_DAG
// maintain the back link in the DocumentObject class if it is from a document object
if (_pcLink && getContainer() && getContainer()->isDerivedFrom(App::DocumentObject::getClassTypeId())) {
App::DocumentObject* parent = static_cast<DocumentObject*>(getContainer());
// before accessing internals make sure the object is not about to be destroyed
// as otherwise the backlink contains dangling pointers
if (!parent->testStatus(ObjectStatus::Destroy)) {
if (_pcLink)
_pcLink->_removeBackLink(parent);
}
}
#endif
}
//**************************************************************************
@@ -202,6 +216,19 @@ PropertyLinkList::PropertyLinkList()
PropertyLinkList::~PropertyLinkList()
{
//in case this property gety dynamically removed
#ifndef USE_OLD_DAG
//maintain the back link in the DocumentObject class
if (!_lValueList.empty() && getContainer() && getContainer()->isDerivedFrom(App::DocumentObject::getClassTypeId())) {
App::DocumentObject* parent = static_cast<DocumentObject*>(getContainer());
// before accessing internals make sure the object is not about to be destroyed
// as otherwise the backlink contains dangling pointers
if (!parent->testStatus(ObjectStatus::Destroy)) {
for(auto *obj : _lValueList)
obj->_removeBackLink(parent);
}
}
#endif
}
@@ -408,7 +435,18 @@ PropertyLinkSub::PropertyLinkSub()
PropertyLinkSub::~PropertyLinkSub()
{
//in case this property is dynamically removed
#ifndef USE_OLD_DAG
if (_pcLinkSub && getContainer() && getContainer()->isDerivedFrom(App::DocumentObject::getClassTypeId())) {
App::DocumentObject* parent = static_cast<DocumentObject*>(getContainer());
// before accessing internals make sure the object is not about to be destroyed
// as otherwise the backlink contains dangling pointers
if (!parent->testStatus(ObjectStatus::Destroy)) {
if (_pcLinkSub)
_pcLinkSub->_removeBackLink(parent);
}
}
#endif
}
//**************************************************************************
@@ -605,7 +643,19 @@ PropertyLinkSubList::PropertyLinkSubList()
PropertyLinkSubList::~PropertyLinkSubList()
{
//in case this property is dynamically removed
#ifndef USE_OLD_DAG
//maintain backlinks
if (!_lValueList.empty() && getContainer() && getContainer()->isDerivedFrom(App::DocumentObject::getClassTypeId())) {
App::DocumentObject* parent = static_cast<DocumentObject*>(getContainer());
// before accessing internals make sure the object is not about to be destroyed
// as otherwise the backlink contains dangling pointers
if (!parent->testStatus(ObjectStatus::Destroy)) {
for(auto *obj : _lValueList)
obj->_removeBackLink(parent);
}
}
#endif
}
void PropertyLinkSubList::setSize(int newSize)