Removed obsolete preference api

src/Mod/Path/InitGui.py

@@ -102,7 +102,7 @@ class PathWorkbench (Workbench):
         specialcmdlist = []
 
 
-        if PathPreferences.toolsReallyUseLegacyTools():
+        if PathPreferences.toolsUseLegacyTools():
             toolcmdlist.append("Path_ToolLibraryEdit")
             toolbitcmdlist = []
         else:

src/Mod/Path/PathScripts/PathPreferences.py

@@ -162,10 +162,6 @@ def toolsUseLegacyTools():
     return preferences().GetBool(UseLegacyTools, False)
 
 
-def toolsReallyUseLegacyTools():
-    return toolsUseLegacyTools()
-
-
 def toolsStoreAbsolutePaths():
     return preferences().GetBool(UseAbsoluteToolPaths, False)
 

src/Mod/Path/PathScripts/PathToolController.py

@@ -226,7 +226,7 @@ class ToolController:
 
 
 def Create(name='TC: Default Tool', tool=None, toolNumber=1, assignViewProvider=True):
-    legacyTool = PathPreferences.toolsReallyUseLegacyTools() if tool is None else isinstance(tool, Path.Tool)
+    legacyTool = PathPreferences.toolsUseLegacyTools() if tool is None else isinstance(tool, Path.Tool)
 
     PathLog.track(tool, toolNumber, legacyTool)
 

src/Mod/Path/PathScripts/PathToolLibraryEditor.py

@@ -439,7 +439,7 @@ class CommandToolLibraryEdit():
         pass
 
     def edit(self, job=None, cb=None):
-        if PathPreferences.toolsReallyUseLegacyTools():
+        if PathPreferences.toolsUseLegacyTools():
             editor = EditorPanel(job, cb)
             editor.setupUi()
             editor.form.exec_()

src/Mod/Path/PathTests/TestPathToolController.py

@@ -37,7 +37,7 @@ class TestPathToolController(PathTestBase):
         FreeCAD.closeDocument(self.doc.Name)
 
     def createTool(self, name='t1', diameter=1.75):
-        if PathPreferences.toolsReallyUseLegacyTools():
+        if PathPreferences.toolsUseLegacyTools():
             return Path.Tool(name=name, diameter=diameter)
         attrs = {'shape': None, 'name': name, 'parameter': {'Diameter': diameter}, 'attribute': []}
         return PathToolBit.Factory.CreateFromAttrs(attrs, name)
@@ -68,7 +68,7 @@ class TestPathToolController(PathTestBase):
         self.assertEqual(attrs['hrapid'], '28.0 mm/s')
         self.assertEqual(attrs['dir'], 'Reverse')
         self.assertEqual(attrs['speed'], 12000)
-        if PathPreferences.toolsReallyUseLegacyTools():
+        if PathPreferences.toolsUseLegacyTools():
             self.assertEqual(attrs['tool'], t.templateAttrs())
         else:
             self.assertEqual(attrs['tool'], t.Proxy.templateAttrs(t))