kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fixes #0003493: Python Shape.isClosed() returns false for any solid, including primitive Parts

Browse Source
This commit is contained in:
wmayer
2018-05-27 15:10:44 +02:00
parent 4b089f9667
commit 0425c7f3c8
2 changed files with 54 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
src/Mod/Part/App/TopoShape.cpp
View File

@@ -1420,7 +1420,54 @@ bool TopoShape::analyze(bool runBopCheck, std::ostream& str) const
bool TopoShape::isClosed() const
{
return BRep_Tool::IsClosed(this->_Shape) ? true : false;
if (this->_Shape.IsNull())
return false;
bool closed = false;
switch (this->_Shape.ShapeType()) {
case TopAbs_SHELL:
case TopAbs_WIRE:
case TopAbs_EDGE:
closed = BRep_Tool::IsClosed(this->_Shape) ? true : false;
break;
case TopAbs_COMPSOLID:
case TopAbs_SOLID:
{
closed = true;
TopExp_Explorer xp(this->_Shape, TopAbs_SHELL);
while (xp.More()) {
closed &= BRep_Tool::IsClosed(xp.Current()) ? true : false;
xp.Next();
}
}
break;
case TopAbs_COMPOUND:
{
closed = true;
TopExp_Explorer xp;
for (xp.Init(this->_Shape, TopAbs_SHELL); xp.More(); xp.Next()) {
closed &= BRep_Tool::IsClosed(xp.Current()) ? true : false;
}
for (xp.Init(this->_Shape, TopAbs_FACE, TopAbs_SHELL); xp.More(); xp.Next()) {
closed &= BRep_Tool::IsClosed(xp.Current()) ? true : false;
}
for (xp.Init(this->_Shape, TopAbs_WIRE, TopAbs_FACE); xp.More(); xp.Next()) {
closed &= BRep_Tool::IsClosed(xp.Current()) ? true : false;
}
for (xp.Init(this->_Shape, TopAbs_EDGE, TopAbs_WIRE); xp.More(); xp.Next()) {
closed &= BRep_Tool::IsClosed(xp.Current()) ? true : false;
}
for (xp.Init(this->_Shape, TopAbs_VERTEX, TopAbs_EDGE); xp.More(); xp.Next()) {
closed &= BRep_Tool::IsClosed(xp.Current()) ? true : false;
}
}
break;
case TopAbs_FACE:
case TopAbs_VERTEX:
case TopAbs_SHAPE:
closed = BRep_Tool::IsClosed(this->_Shape) ? true : false;
break;
}
return closed;
}
TopoDS_Shape TopoShape::cut(TopoDS_Shape shape) const

7
src/Mod/Part/App/TopoShapePy.xml
View File

@@ -443,7 +443,12 @@ As a result, this shape becomes null.</UserDocu>
</Methode>
<Methode Name="isClosed" Const="true">
<Documentation>
<UserDocu>Checks if the shape is closed.</UserDocu>
<UserDocu>Checks if the shape is closed
If the shape is a shell it returns True if it has no free boundaries (edges).
If the shape is a wire it returns True if it has no free ends (vertices).
(Internal and External sub-shepes are ignored in these checks)
If the shape is an edge it returns True if its vertices are the same.
</UserDocu>
</Documentation>
</Methode>
<Methode Name="isPartner" Const="true">