kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Coverity fixes

Browse Source 
CID 156629  - obsolete
CID 156624  - obsolete
CID 163225  - won't fix
CID 163226
CID 163227
CID 163228
CID 163229
CID 163235
This commit is contained in:
WandererFan
2017-06-21 11:32:06 -04:00
committed by wmayer
parent f56df2ebee
commit 0768ae99cf
3 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/TechDraw/Gui/QGIFace.cpp
View File

@@ -228,12 +228,12 @@ void QGIFace::clearLineSets(void)
clearFillItems();
}
void QGIFace::addLineSet(LineSet ls)
void QGIFace::addLineSet(LineSet& ls)
{
m_lineSets.push_back(ls);
}
void QGIFace::lineSetToFillItems(LineSet ls)
void QGIFace::lineSetToFillItems(LineSet& ls)
{
m_segCount = 0;
QPen pen = setGeomPen();
@@ -285,7 +285,7 @@ QGraphicsPathItem* QGIFace::lineFromPoints(Base::Vector3d start, Base::Vector3d
return fillItem;
}
QGraphicsPathItem* QGIFace::geomToLine(TechDrawGeometry::BaseGeom* base, LineSet ls)
QGraphicsPathItem* QGIFace::geomToLine(TechDrawGeometry::BaseGeom* base, LineSet& ls)
{
QGraphicsPathItem* fillItem = new QGraphicsPathItem(this);
Base::Vector3d start(base->getStartPoint().x,
@@ -302,7 +302,7 @@ QGraphicsPathItem* QGIFace::geomToLine(TechDrawGeometry::BaseGeom* base, LineSe
//! make a fragment (length = remain) of a dashed line, with pattern starting at +offset
QGraphicsPathItem* QGIFace::geomToStubbyLine(TechDrawGeometry::BaseGeom* base, double remain, LineSet ls)
QGraphicsPathItem* QGIFace::geomToStubbyLine(TechDrawGeometry::BaseGeom* base, double remain, LineSet& ls)
{
QGraphicsPathItem* fillItem = new QGraphicsPathItem(this);
Base::Vector3d start(base->getStartPoint().x,

10
src/Mod/TechDraw/Gui/QGIFace.h
View File

@@ -106,13 +106,13 @@ public:
void setLineWeight(double w);
void clearLineSets(void);
void addLineSet(LineSet ls);
void addLineSet(LineSet& ls);
void clearFillItems(void);
void lineSetToFillItems(LineSet ls);
QGraphicsPathItem* geomToLine(TechDrawGeometry::BaseGeom* base, LineSet ls);
QGraphicsPathItem* geomToOffsetLine(TechDrawGeometry::BaseGeom* base, double offset, LineSet ls);
QGraphicsPathItem* geomToStubbyLine(TechDrawGeometry::BaseGeom* base, double offset, LineSet ls);
void lineSetToFillItems(LineSet& ls);
QGraphicsPathItem* geomToLine(TechDrawGeometry::BaseGeom* base,LineSet& ls);
// QGraphicsPathItem* geomToOffsetLine(TechDrawGeometry::BaseGeom* base, double offset, const LineSet& ls);
QGraphicsPathItem* geomToStubbyLine(TechDrawGeometry::BaseGeom* base, double offset, LineSet& ls);
QGraphicsPathItem* lineFromPoints(Base::Vector3d start, Base::Vector3d end, DashSpec ds);
//bitmap texture fill parms method

1
src/Mod/TechDraw/Gui/QGIHighlight.cpp
View File

@@ -41,6 +41,7 @@ using namespace TechDrawGui;
QGIHighlight::QGIHighlight()
{
m_refSize = 0.0;
m_circle = new QGraphicsEllipseItem();
addToGroup(m_circle);
m_rect = new QGCustomRect();