[TechDraw] Improve readability of TaskLineDim.cpp

This commit is contained in:
Benjamin Bræstrup Sayoc
2022-07-12 17:12:37 +02:00
committed by WandererFan
parent 664426d394
commit 096f471426

View File

@@ -144,37 +144,38 @@ void TaskLinkDim::loadToTree(const TechDraw::DrawViewDimension* dim, const bool
//! does this dim already have a reference to the selection?
bool TaskLinkDim::dimReferencesSelection(const TechDraw::DrawViewDimension* dim) const
{
bool result = false;
if (!dim->has3DReferences()) {
return result;
return false;
}
std::vector<App::DocumentObject*> refParts = dim->References3D.getValues();
std::vector<std::string> refSubs = dim->References3D.getSubValues();
if (refParts.size() == m_parts.size()) {
if(refParts.size() == 0) {
//shouldn't happen!
} else if (refParts.size() == 1) {
if ((refParts[0] == m_parts[0]) &&
(refSubs[0] == m_subs[0]) ) { //everything matches
result = true;
}
} else if (refParts.size() == 2) {
if (( (refParts[0] == m_parts[0]) &&
(refParts[1] == m_parts[1]) ) &&
( (refSubs[0] == m_subs[0]) &&
(refSubs[1] == m_subs[1]) ) ) {
result = true;
} else if (( (refParts[0] == m_parts[1]) &&
(refParts[1] == m_parts[0]) ) &&
( (refSubs[0] == m_subs[1]) &&
(refSubs[1] == m_subs[0]) ) ) {
result = true;
}
if (refParts.size() != m_parts.size()) {
return false;
}
if(refParts.size() == 0) {
//shouldn't happen!
} else if (refParts.size() == 1) {
if ((refParts[0] == m_parts[0]) &&
(refSubs[0] == m_subs[0]) ) { //everything matches
return true;
}
} else if (refParts.size() == 2) {
if (( (refParts[0] == m_parts[0]) &&
(refParts[1] == m_parts[1]) ) &&
( (refSubs[0] == m_subs[0]) &&
(refSubs[1] == m_subs[1]) ) ) {
return true;
} else if (( (refParts[0] == m_parts[1]) &&
(refParts[1] == m_parts[0]) ) &&
( (refSubs[0] == m_subs[1]) &&
(refSubs[1] == m_subs[0]) ) ) {
return true;
}
}
return result;
return false;
}
void TaskLinkDim::updateDims()