issue #0004188: Editing a subtractive box in PartDesign doesn't show the shaded box

src/Mod/Part/Gui/TaskAttacher.cpp

@@ -109,11 +109,11 @@ void TaskAttacher::makeRefStrings(std::vector<QString>& refstrings, std::vector<
 }
 
 TaskAttacher::TaskAttacher(Gui::ViewProviderDocumentObject *ViewProvider, QWidget *parent,
-                           QString picture, QString text)
+                           QString picture, QString text, TaskAttacher::VisibilityFunction visFunc)
     : TaskBox(Gui::BitmapFactory().pixmap(picture.toLatin1()), text, true, parent),
       SelectionObserver(ViewProvider),
       ViewProvider(ViewProvider),
-      visibilityFunc(0)
+      visibilityFunc(visFunc)
 {
     //check if we are attachable
     if (!ViewProvider->getObject()->hasExtension(Part::AttachExtension::getExtensionClassTypeId()))

src/Mod/Part/Gui/TaskAttacher.h

@@ -57,7 +57,7 @@ public:
 
     TaskAttacher(Gui::ViewProviderDocumentObject *ViewProvider, QWidget *parent = 0,
                  QString picture = QString(),
-                 QString text = QString::fromLatin1("Attachment"));
+                 QString text = QString::fromLatin1("Attachment"), VisibilityFunction func = 0);
     ~TaskAttacher();
 
     bool   getFlip(void) const;
@@ -69,15 +69,6 @@ public:
      */
     Attacher::eMapMode getActiveMapMode();
 
-    /**
-     * @brief setCustomVisibilityAutomation sets a customized function
-     * in order to allow to handle visibility automation differently than
-     * the default implementation.
-     */
-    void setCustomVisibilityAutomation(VisibilityFunction func) {
-        visibilityFunc = func;
-    }
-
     bool isCompleted() const { return completed; }
 
 private Q_SLOTS:

src/Mod/PartDesign/Gui/TaskPrimitiveParameters.cpp

@@ -690,8 +690,7 @@ TaskPrimitiveParameters::TaskPrimitiveParameters(ViewProviderPrimitive* Primitiv
         }
     };
 
-    parameter = new PartGui::TaskAttacher(PrimitiveView);
-    parameter->setCustomVisibilityAutomation(customvisfunc);
+    parameter = new PartGui::TaskAttacher(PrimitiveView, nullptr, QString(), tr("Attachment"), customvisfunc);
     Content.push_back(parameter);
 }