kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[MOD] Fix premature evaluation and recursive updates in Image Plane Settings (#26390)

Browse Source 
* Fixed image editor

* decoupled the chnage height and width fns

* final fixes
This commit is contained in:
Rahul Paul
2025-12-29 22:04:29 +05:30
committed by GitHub
parent 20e45231c5
commit 1002bcb398
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Gui/TaskView/TaskImage.cpp
View File

@@ -106,9 +106,9 @@ void TaskImage::connectSignals()
connect(ui->sliderTransparency, qOverload<int>(&QSlider::valueChanged),
this, &TaskImage::changeTransparency);
connect(ui->spinBoxWidth, qOverload<double>(&QuantitySpinBox::valueChanged),
connect(ui->spinBoxWidth, &QuantitySpinBox::editingFinished,
this, &TaskImage::changeWidth);
connect(ui->spinBoxHeight, qOverload<double>(&QuantitySpinBox::valueChanged),
connect(ui->spinBoxHeight, &QuantitySpinBox::editingFinished,
this, &TaskImage::changeHeight);
connect(ui->pushButtonScale, &QPushButton::clicked,
this, &TaskImage::onInteractiveScale);
@@ -150,25 +150,29 @@ void TaskImage::changeTransparency(int val)
}
}
void TaskImage::changeWidth(double val)
void TaskImage::changeWidth()
{
if (!feature.expired()) {
double val = ui->spinBoxWidth->value().getValue();
feature->XSize.setValue(val);
if (ui->checkBoxRatio->isChecked()) {
QSignalBlocker block(ui->spinBoxWidth);
feature->YSize.setValue(val / aspectRatio);
QSignalBlocker block(ui->spinBoxHeight);
ui->spinBoxHeight->setValue(val / aspectRatio);
}
}
}
void TaskImage::changeHeight(double val)
void TaskImage::changeHeight()
{
if (!feature.expired()) {
double val = ui->spinBoxHeight->value().getValue();
feature->YSize.setValue(val);
if (ui->checkBoxRatio->isChecked()) {
QSignalBlocker block(ui->spinBoxHeight);
feature->XSize.setValue(val * aspectRatio);
QSignalBlocker block(ui->spinBoxWidth);
ui->spinBoxWidth->setValue(val * aspectRatio);
}
}

4
src/Gui/TaskView/TaskImage.h
View File

@@ -120,8 +120,8 @@ private:
private:
void changeTransparency(int val);
void changeWidth(double val);
void changeHeight(double val);
void changeWidth();
void changeHeight();
private:
std::unique_ptr<Ui_TaskImage> ui;