kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

FEM: Ensure node is valid before accessing

Browse Source 
Coverity issue 545293
This commit is contained in:
Chris Hennes
2025-03-20 23:37:56 -05:00
committed by Benjamin Nauck
parent 47615b8464
commit 1092c9704a
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Mod/Fem/App/FemVTKTools.cpp
View File

@@ -1479,8 +1479,8 @@ void readResults(std::ifstream& ifstr,
// enter in node values block
std::string code1 = " -1";
std::string code2 = " -2";
int node;
double value;
int node {-1};
double value {0.0};
std::vector<double> vecValues;
std::vector<double> scaValues;
std::vector<int> nodes;
@@ -1563,9 +1563,15 @@ void readResults(std::ifstream& ifstr,
}
if ((vecValues.size() + scaValues.size()) == numComps) {
if (!vecValues.empty()) {
if (node == -1) {
throw Base::FileException("File to load not readable");
}
vecArray->SetTuple(mapNodes.at(node), vecValues.data());
}
if (!scaValues.empty()) {
if (node == -1) {
throw Base::FileException("File to load not readable");
}
std::vector<vtkSmartPointer<vtkDoubleArray>>::iterator it1;
std::vector<double>::iterator it2;
for (it1 = scaArrays.begin(), it2 = scaValues.begin();