kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: Process minor review comments

Browse Source 
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
This commit is contained in:
Pieter Hijma
2025-09-12 09:54:20 +02:00
parent 459a8bc4c8
commit 12b7699800
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/Gui/Dialogs/DlgAddProperty.cpp
View File

@@ -481,14 +481,8 @@ void DlgAddProperty::setAddEnabled(bool enabled)
{
QPushButton *addButton = ui->buttonBox->button(QDialogButtonBox::Ok);
QPushButton *cancelButton = ui->buttonBox->button(QDialogButtonBox::Cancel);
if (enabled) {
cancelButton->setDefault(false);
addButton->setDefault(true);
}
else {
cancelButton->setDefault(true);
addButton->setDefault(false);
}
cancelButton->setDefault(!enabled);
addButton->setDefault(enabled);
addButton->setEnabled(enabled);
}
@@ -550,12 +544,12 @@ bool DlgAddProperty::isTypeValid()
bool DlgAddProperty::isDocument() const
{
return container && freecad_cast<const App::Document*>(container);
return container->isDerivedFrom<App::Document>();
}
bool DlgAddProperty::isDocumentObject() const
{
return container && freecad_cast<const App::DocumentObject*>(container);
return container->isDerivedFrom<App::DocumentObject>();
}
bool DlgAddProperty::areFieldsValid()
@@ -830,9 +824,8 @@ void DlgAddProperty::openTransaction()
void DlgAddProperty::critical(const QString& title, const QString& text) {
static bool criticalDialogShown = false;
if (!criticalDialogShown) {
criticalDialogShown = true;
Base::StateLocker locker(criticalDialogShown);
QMessageBox::critical(this, title, text);
criticalDialogShown = false;
}
}