kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: prevent crash on undo/redo while dragging.

Browse Source 
Fixes #25500
This commit is contained in:
pjcreath
2025-11-20 15:22:20 -05:00
committed by Chris Hennes
parent eb0c980c1d
commit 16aff10544
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp
View File

@@ -653,6 +653,14 @@ ViewProviderSketch::~ViewProviderSketch()
void ViewProviderSketch::slotUndoDocument(const Gui::Document& /*doc*/)
{
// If undo is triggered during a drag operation, the drag must be canceled to avoid using
// stale geometry IDs, which would lead to a crash.
if (!drag.Dragged.empty() || !drag.DragConstraintSet.empty()) {
drag.reset();
setSketchMode(STATUS_NONE);
resetPositionText();
}
// Note 1: this slot is only operative during edit mode (see signal connection/disconnection)
// Note 2: ViewProviderSketch::UpdateData does not generate updates during undo/redo
// transactions as mid-transaction data may not be in a valid state (e.g. constraints
@@ -664,6 +672,14 @@ void ViewProviderSketch::slotUndoDocument(const Gui::Document& /*doc*/)
void ViewProviderSketch::slotRedoDocument(const Gui::Document& /*doc*/)
{
// If redo is triggered during a drag operation, the drag must be canceled to avoid using
// stale geometry IDs, which would lead to a crash.
if (!drag.Dragged.empty() || !drag.DragConstraintSet.empty()) {
drag.reset();
setSketchMode(STATUS_NONE);
resetPositionText();
}
// Note 1: this slot is only operative during edit mode (see signal connection/disconnection)
// Note 2: ViewProviderSketch::UpdateData does not generate updates during undo/redo
// transactions as mid-transaction data may not be in a valid state (e.g. constraints