kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Mod: Single arg ctors must be explicit

Browse Source
This commit is contained in:
berniev
2022-08-15 19:28:04 +10:00
committed by wwmayer
parent 3877fc62c3
commit 180edfa3cc
263 changed files with 473 additions and 473 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/TechDraw/App/Cosmetic.h
View File

@@ -307,7 +307,7 @@ class TechDrawExport GeomFormat: public Base::Persistence
public:
GeomFormat();
GeomFormat(TechDraw::GeomFormat* gf);
explicit GeomFormat(TechDraw::GeomFormat* gf);
GeomFormat(int idx,
LineFormat fmt);
~GeomFormat() override;

20
src/Mod/TechDraw/App/Geometry.h
View File

@@ -161,7 +161,7 @@ class TechDrawExport Circle: public BaseGeom
{
public:
Circle();
Circle(const TopoDS_Edge &e);
explicit Circle(const TopoDS_Edge &e);
Circle(Base::Vector3d center, double radius);
~Circle() override = default;
@@ -177,7 +177,7 @@ class TechDrawExport Circle: public BaseGeom
class TechDrawExport Ellipse: public BaseGeom
{
public:
Ellipse(const TopoDS_Edge &e);
explicit Ellipse(const TopoDS_Edge &e);
Ellipse(Base::Vector3d c, double mnr, double mjr);
~Ellipse() override = default;
@@ -193,7 +193,7 @@ class TechDrawExport Ellipse: public BaseGeom
class TechDrawExport AOE: public Ellipse
{
public:
AOE(const TopoDS_Edge &e);
explicit AOE(const TopoDS_Edge &e);
~AOE() override = default;
public:
@@ -215,7 +215,7 @@ class TechDrawExport AOE: public Ellipse
class TechDrawExport AOC: public Circle
{
public:
AOC(const TopoDS_Edge &e);
explicit AOC(const TopoDS_Edge &e);
AOC(Base::Vector3d c, double r, double s, double e);
AOC();
~AOC() override = default;
@@ -247,7 +247,7 @@ class TechDrawExport AOC: public Circle
class TechDrawExport BezierSegment: public BaseGeom
{
public:
BezierSegment(const TopoDS_Edge &e);
explicit BezierSegment(const TopoDS_Edge &e);
BezierSegment() { poles = degree = 0; }
~BezierSegment() override = default;
@@ -260,7 +260,7 @@ public:
class TechDrawExport BSpline: public BaseGeom
{
public:
BSpline(const TopoDS_Edge &e);
explicit BSpline(const TopoDS_Edge &e);
~BSpline() override = default;
public:
@@ -284,7 +284,7 @@ class TechDrawExport BSpline: public BaseGeom
class TechDrawExport Generic: public BaseGeom
{
public:
Generic(const TopoDS_Edge &e);
explicit Generic(const TopoDS_Edge &e);
Generic();
~Generic() override = default;
@@ -303,7 +303,7 @@ class TechDrawExport Wire
{
public:
Wire();
Wire(const TopoDS_Wire &w);
explicit Wire(const TopoDS_Wire &w);
~Wire();
TopoDS_Wire toOccWire() const;
@@ -326,9 +326,9 @@ class TechDrawExport Vertex
{
public:
Vertex();
Vertex(const Vertex* v);
explicit Vertex(const Vertex* v);
Vertex(double x, double y);
Vertex(Base::Vector3d v);
explicit Vertex(Base::Vector3d v);
virtual ~Vertex() {}
virtual void Save(Base::Writer &/*writer*/) const;

4
src/Mod/TechDraw/App/HatchLine.h
View File

@@ -52,7 +52,7 @@ class TechDrawExport DashSpec
{
public:
DashSpec() {}
DashSpec(std::vector<double> p) { m_parms = p; }
explicit DashSpec(std::vector<double> p) { m_parms = p; }
~DashSpec() {}
double get(int i) {return m_parms.at(i); }
@@ -72,7 +72,7 @@ class TechDrawExport PATLineSpec
{
public:
PATLineSpec();
PATLineSpec(std::string& lineSpec);
explicit PATLineSpec(std::string& lineSpec);
~PATLineSpec();
void load(std::string& lineSpec);

2
src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.h
View File

@@ -38,7 +38,7 @@ class DlgPrefsTechDrawAdvancedImp : public Gui::Dialog::PreferencePage
Q_OBJECT
public:
DlgPrefsTechDrawAdvancedImp( QWidget* parent = nullptr );
explicit DlgPrefsTechDrawAdvancedImp( QWidget* parent = nullptr );
~DlgPrefsTechDrawAdvancedImp() override;
protected:

2
src/Mod/TechDraw/Gui/DlgPrefsTechDrawAnnotationImp.h
View File

@@ -38,7 +38,7 @@ class DlgPrefsTechDrawAnnotationImp : public Gui::Dialog::PreferencePage
Q_OBJECT
public:
DlgPrefsTechDrawAnnotationImp( QWidget* parent = nullptr );
explicit DlgPrefsTechDrawAnnotationImp( QWidget* parent = nullptr );
~DlgPrefsTechDrawAnnotationImp() override;
public Q_SLOTS:

2
src/Mod/TechDraw/Gui/DlgPrefsTechDrawColorsImp.h
View File

@@ -38,7 +38,7 @@ class DlgPrefsTechDrawColorsImp : public Gui::Dialog::PreferencePage
Q_OBJECT
public:
DlgPrefsTechDrawColorsImp( QWidget* parent = nullptr );
explicit DlgPrefsTechDrawColorsImp( QWidget* parent = nullptr );
~DlgPrefsTechDrawColorsImp() override;
protected:

2
src/Mod/TechDraw/Gui/DlgPrefsTechDrawDimensionsImp.h
View File

@@ -38,7 +38,7 @@ class DlgPrefsTechDrawDimensionsImp : public Gui::Dialog::PreferencePage
Q_OBJECT
public:
DlgPrefsTechDrawDimensionsImp( QWidget* parent = nullptr );
explicit DlgPrefsTechDrawDimensionsImp( QWidget* parent = nullptr );
~DlgPrefsTechDrawDimensionsImp() override;
protected:

2
src/Mod/TechDraw/Gui/DlgPrefsTechDrawGeneralImp.h
View File

@@ -38,7 +38,7 @@ class DlgPrefsTechDrawGeneralImp : public Gui::Dialog::PreferencePage
Q_OBJECT
public:
DlgPrefsTechDrawGeneralImp( QWidget* parent = nullptr );
explicit DlgPrefsTechDrawGeneralImp( QWidget* parent = nullptr );
~DlgPrefsTechDrawGeneralImp() override;
protected:

2
src/Mod/TechDraw/Gui/DlgPrefsTechDrawHLRImp.h
View File

@@ -38,7 +38,7 @@ class DlgPrefsTechDrawHLRImp : public Gui::Dialog::PreferencePage
Q_OBJECT
public:
DlgPrefsTechDrawHLRImp( QWidget* parent = nullptr );
explicit DlgPrefsTechDrawHLRImp( QWidget* parent = nullptr );
~DlgPrefsTechDrawHLRImp() override;
protected:

2
src/Mod/TechDraw/Gui/DlgPrefsTechDrawScaleImp.h
View File

@@ -38,7 +38,7 @@ class DlgPrefsTechDrawScaleImp : public Gui::Dialog::PreferencePage
Q_OBJECT
public:
DlgPrefsTechDrawScaleImp( QWidget* parent = nullptr );
explicit DlgPrefsTechDrawScaleImp( QWidget* parent = nullptr );
~DlgPrefsTechDrawScaleImp() override;
protected Q_SLOTS:

2
src/Mod/TechDraw/Gui/DlgTemplateField.h
View File

@@ -38,7 +38,7 @@ class DlgTemplateField : public QDialog
Q_OBJECT
public:
DlgTemplateField( QWidget *parent = nullptr );
explicit DlgTemplateField( QWidget *parent = nullptr );
~DlgTemplateField() override = default;
void setFieldName(std::string name);

2
src/Mod/TechDraw/Gui/MDIViewPage.h
View File

@@ -159,7 +159,7 @@ public:
using BaseType = Py::PythonExtension<MDIViewPagePy>;
static void init_type();
MDIViewPagePy(MDIViewPage *mdi);
explicit MDIViewPagePy(MDIViewPage *mdi);
~MDIViewPagePy() override;
Py::Object repr() override;

2
src/Mod/TechDraw/Gui/QGIDrawingTemplate.h
View File

@@ -45,7 +45,7 @@ class TechDrawGuiExport QGIDrawingTemplate : public QGITemplate
Q_OBJECT
public:
QGIDrawingTemplate(QGSPage *);
explicit QGIDrawingTemplate(QGSPage *);
~QGIDrawingTemplate();
enum {Type = QGraphicsItem::UserType + 151};

2
src/Mod/TechDraw/Gui/QGISVGTemplate.h
View File

@@ -48,7 +48,7 @@ class TechDrawGuiExport QGISVGTemplate : public QGITemplate
Q_OBJECT
public:
QGISVGTemplate(QGSPage* scene);
explicit QGISVGTemplate(QGSPage* scene);
virtual ~QGISVGTemplate();
enum {Type = QGraphicsItem::UserType + 153};

2
src/Mod/TechDraw/Gui/QGSPage.h
View File

@@ -70,7 +70,7 @@ class TechDrawGuiExport QGSPage : public QGraphicsScene
Q_OBJECT
public:
QGSPage(ViewProviderPage *vp, QWidget *parent = nullptr);
explicit QGSPage(ViewProviderPage *vp, QWidget *parent = nullptr);
~QGSPage() override;
bool addView(const App::DocumentObject *obj);

2
src/Mod/TechDraw/Gui/QGVNavStyle.h
View File

@@ -62,7 +62,7 @@ private:
class TechDrawGuiExport QGVNavStyle : public Base::BaseClass
{
public:
QGVNavStyle(QGVPage* qgvp);
explicit QGVNavStyle(QGVPage* qgvp);
~QGVNavStyle() override;
void setViewer(QGVPage* qgvp) { m_viewer = qgvp;} ;

2
src/Mod/TechDraw/Gui/QGVNavStyleBlender.h
View File

@@ -35,7 +35,7 @@ class QGVPage;
class TechDrawGuiExport QGVNavStyleBlender : public QGVNavStyle
{
public:
QGVNavStyleBlender(QGVPage* qgvp);
explicit QGVNavStyleBlender(QGVPage* qgvp);
~QGVNavStyleBlender() override;
void handleKeyReleaseEvent(QKeyEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVNavStyleCAD.h
View File

@@ -35,7 +35,7 @@ class QGVPage;
class TechDrawGuiExport QGVNavStyleCAD : public QGVNavStyle
{
public:
QGVNavStyleCAD(QGVPage* qgvp);
explicit QGVNavStyleCAD(QGVPage* qgvp);
~QGVNavStyleCAD() override;
void handleKeyReleaseEvent(QKeyEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVNavStyleGesture.h
View File

@@ -35,7 +35,7 @@ class QGVPage;
class TechDrawGuiExport QGVNavStyleGesture : public QGVNavStyle
{
public:
QGVNavStyleGesture(QGVPage* qgvp);
explicit QGVNavStyleGesture(QGVPage* qgvp);
~QGVNavStyleGesture() override;
void handleMousePressEvent(QMouseEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVNavStyleInventor.h
View File

@@ -35,7 +35,7 @@ class QGVPage;
class TechDrawGuiExport QGVNavStyleInventor : public QGVNavStyle
{
public:
QGVNavStyleInventor(QGVPage* qgvp);
explicit QGVNavStyleInventor(QGVPage* qgvp);
~QGVNavStyleInventor() override;
void handleMousePressEvent(QMouseEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVNavStyleMaya.h
View File

@@ -35,7 +35,7 @@ class QGVPage;
class TechDrawGuiExport QGVNavStyleMaya : public QGVNavStyle
{
public:
QGVNavStyleMaya(QGVPage* qgvp);
explicit QGVNavStyleMaya(QGVPage* qgvp);
~QGVNavStyleMaya() override;
void handleKeyReleaseEvent(QKeyEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVNavStyleOCC.h
View File

@@ -35,7 +35,7 @@ class QGVPage;
class TechDrawGuiExport QGVNavStyleOCC : public QGVNavStyle
{
public:
QGVNavStyleOCC(QGVPage* qgvp);
explicit QGVNavStyleOCC(QGVPage* qgvp);
~QGVNavStyleOCC() override;
void handleKeyReleaseEvent(QKeyEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVNavStyleOpenSCAD.h
View File

@@ -35,7 +35,7 @@ class QGVPage;
class TechDrawGuiExport QGVNavStyleOpenSCAD : public QGVNavStyle
{
public:
QGVNavStyleOpenSCAD(QGVPage* qgvp);
explicit QGVNavStyleOpenSCAD(QGVPage* qgvp);
~QGVNavStyleOpenSCAD() override;
void handleKeyReleaseEvent(QKeyEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVNavStyleRevit.h
View File

@@ -35,7 +35,7 @@ class QGVPage;
class TechDrawGuiExport QGVNavStyleRevit : public QGVNavStyle
{
public:
QGVNavStyleRevit(QGVPage* qgvp);
explicit QGVNavStyleRevit(QGVPage* qgvp);
~QGVNavStyleRevit() override;
void handleMousePressEvent(QMouseEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVNavStyleTinkerCAD.h
View File

@@ -37,7 +37,7 @@ class TechDrawGuiExport QGVNavStyleTinkerCAD : public QGVNavStyle
// TYPESYSTEM_HEADER();
public:
QGVNavStyleTinkerCAD(QGVPage* qgvp);
explicit QGVNavStyleTinkerCAD(QGVPage* qgvp);
~QGVNavStyleTinkerCAD() override;
void handleMouseMoveEvent(QMouseEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVNavStyleTouchpad.h
View File

@@ -35,7 +35,7 @@ class QGVPage;
class TechDrawGuiExport QGVNavStyleTouchpad : public QGVNavStyle
{
public:
QGVNavStyleTouchpad(QGVPage* qgvp);
explicit QGVNavStyleTouchpad(QGVPage* qgvp);
~QGVNavStyleTouchpad() override;
void handleKeyPressEvent(QKeyEvent *event) override;

2
src/Mod/TechDraw/Gui/QGVPage.cpp
View File

@@ -189,7 +189,7 @@ public:
/// handle to the viewer parameter group
ParameterGrp::handle hGrp;
QGVPage* page;
Private(QGVPage* page) : page(page) {
explicit Private(QGVPage* page) : page(page) {
// attach parameter Observer
hGrp = App::GetApplication().GetParameterGroupByPath("User parameter:BaseApp/Preferences/View");
hGrp->Attach(this);

2
src/Mod/TechDraw/Gui/TaskActiveView.h
View File

@@ -91,7 +91,7 @@ class TaskDlgActiveView : public Gui::TaskView::TaskDialog
Q_OBJECT
public:
TaskDlgActiveView(TechDraw::DrawPage* pageFeat);
explicit TaskDlgActiveView(TechDraw::DrawPage* pageFeat);
~TaskDlgActiveView() override;
public:

4
src/Mod/TechDraw/Gui/TaskCustomizeFormat.h
View File

@@ -62,7 +62,7 @@ class TaskCustomizeFormat : public QWidget
Q_OBJECT
public:
TaskCustomizeFormat(App::DocumentObject * object);
explicit TaskCustomizeFormat(App::DocumentObject * object);
~TaskCustomizeFormat() override;
public Q_SLOTS:
@@ -95,7 +95,7 @@ class TaskDlgCustomizeFormat : public Gui::TaskView::TaskDialog
Q_OBJECT
public:
TaskDlgCustomizeFormat(App::DocumentObject * object);
explicit TaskDlgCustomizeFormat(App::DocumentObject * object);
~TaskDlgCustomizeFormat() override;
public:

8
src/Mod/TechDraw/Gui/TaskDetail.h
View File

@@ -60,8 +60,8 @@ class TaskDetail : public QWidget
Q_OBJECT
public:
TaskDetail(TechDraw::DrawViewPart* baseFeat);
TaskDetail(TechDraw::DrawViewDetail* detailFeat);
explicit TaskDetail(TechDraw::DrawViewPart* baseFeat);
explicit TaskDetail(TechDraw::DrawViewDetail* detailFeat);
~TaskDetail() override;
public Q_SLOTS:
@@ -140,8 +140,8 @@ class TaskDlgDetail : public Gui::TaskView::TaskDialog
Q_OBJECT
public:
TaskDlgDetail(TechDraw::DrawViewPart* baseFeat);
TaskDlgDetail(TechDraw::DrawViewDetail* detailFeat);
explicit TaskDlgDetail(TechDraw::DrawViewPart* baseFeat);
explicit TaskDlgDetail(TechDraw::DrawViewDetail* detailFeat);
~TaskDlgDetail() override;
public:

4
src/Mod/TechDraw/Gui/TaskHatch.h
View File

@@ -51,7 +51,7 @@ class TaskHatch : public QWidget
public:
TaskHatch(TechDraw::DrawViewPart* inDvp, std::vector<std::string> subs);
TaskHatch(TechDrawGui::ViewProviderHatch* inVp);
explicit TaskHatch(TechDrawGui::ViewProviderHatch* inVp);
~TaskHatch() override;
public:
@@ -100,7 +100,7 @@ class TaskDlgHatch : public Gui::TaskView::TaskDialog
public:
TaskDlgHatch(TechDraw::DrawViewPart* inDvp, std::vector<std::string> subs);
TaskDlgHatch(TechDrawGui::ViewProviderHatch* inVp);
explicit TaskDlgHatch(TechDrawGui::ViewProviderHatch* inVp);
~TaskDlgHatch() override;
public:

4
src/Mod/TechDraw/Gui/TaskLeaderLine.h
View File

@@ -65,7 +65,7 @@ class TaskLeaderLine : public QWidget
public:
TaskLeaderLine(TechDraw::DrawView* baseFeat,
TechDraw::DrawPage* page);
TaskLeaderLine(TechDrawGui::ViewProviderLeader* leadVP);
explicit TaskLeaderLine(TechDrawGui::ViewProviderLeader* leadVP);
~TaskLeaderLine() override;
public Q_SLOTS:
@@ -168,7 +168,7 @@ class TaskDlgLeaderLine : public Gui::TaskView::TaskDialog
public:
TaskDlgLeaderLine(TechDraw::DrawView* baseFeat,
TechDraw::DrawPage* page);
TaskDlgLeaderLine(TechDrawGui::ViewProviderLeader* leadVP);
explicit TaskDlgLeaderLine(TechDrawGui::ViewProviderLeader* leadVP);
~TaskDlgLeaderLine() override;
public:

4
src/Mod/TechDraw/Gui/TaskRichAnno.h
View File

@@ -58,7 +58,7 @@ class TaskRichAnno : public QWidget
public:
TaskRichAnno(TechDraw::DrawView* baseFeat,
TechDraw::DrawPage* page);
TaskRichAnno(TechDrawGui::ViewProviderRichAnno* leadVP);
explicit TaskRichAnno(TechDrawGui::ViewProviderRichAnno* leadVP);
~TaskRichAnno() override;
public Q_SLOTS:
@@ -134,7 +134,7 @@ class TaskDlgRichAnno : public Gui::TaskView::TaskDialog
public:
TaskDlgRichAnno(TechDraw::DrawView* baseFeat,
TechDraw::DrawPage* page);
TaskDlgRichAnno(TechDrawGui::ViewProviderRichAnno* leadVP);
explicit TaskDlgRichAnno(TechDrawGui::ViewProviderRichAnno* leadVP);
~TaskDlgRichAnno() override;
public:

8
src/Mod/TechDraw/Gui/TaskSectionView.h
View File

@@ -44,8 +44,8 @@ class TaskSectionView : public QWidget
Q_OBJECT
public:
TaskSectionView(TechDraw::DrawViewPart* base);
TaskSectionView(TechDraw::DrawViewSection* section);
explicit TaskSectionView(TechDraw::DrawViewPart* base);
explicit TaskSectionView(TechDraw::DrawViewSection* section);
~TaskSectionView() override;
public:
@@ -124,8 +124,8 @@ class TaskDlgSectionView : public Gui::TaskView::TaskDialog
Q_OBJECT
public:
TaskDlgSectionView(TechDraw::DrawViewPart* base);
TaskDlgSectionView(TechDraw::DrawViewSection* section);
explicit TaskDlgSectionView(TechDraw::DrawViewPart* base);
explicit TaskDlgSectionView(TechDraw::DrawViewSection* section);
~TaskDlgSectionView() override;
public:

4
src/Mod/TechDraw/Gui/TaskSelectLineAttributes.h
View File

@@ -93,7 +93,7 @@ class TaskSelectLineAttributes : public QWidget
Q_OBJECT
public:
TaskSelectLineAttributes(lineAttributes * ptActiveAttributes);
explicit TaskSelectLineAttributes(lineAttributes * ptActiveAttributes);
~TaskSelectLineAttributes() override;
public Q_SLOTS:
@@ -120,7 +120,7 @@ class TaskDlgSelectLineAttributes : public Gui::TaskView::TaskDialog
Q_OBJECT
public:
TaskDlgSelectLineAttributes(lineAttributes * ptActiveAttributes);
explicit TaskDlgSelectLineAttributes(lineAttributes * ptActiveAttributes);
~TaskDlgSelectLineAttributes() override;
public:

4
src/Mod/TechDraw/Gui/TaskSurfaceFinishSymbols.h
View File

@@ -77,7 +77,7 @@ class TaskSurfaceFinishSymbols : public QWidget
Q_OBJECT
public:
TaskSurfaceFinishSymbols(TechDraw::DrawViewPart* view);
explicit TaskSurfaceFinishSymbols(TechDraw::DrawViewPart* view);
~TaskSurfaceFinishSymbols() override;
public Q_SLOTS:
@@ -120,7 +120,7 @@ class TaskDlgSurfaceFinishSymbols : public Gui::TaskView::TaskDialog
Q_OBJECT
public:
TaskDlgSurfaceFinishSymbols(TechDraw::DrawViewPart* view);
explicit TaskDlgSurfaceFinishSymbols(TechDraw::DrawViewPart* view);
~TaskDlgSurfaceFinishSymbols() override;
public:

4
src/Mod/TechDraw/Gui/TaskWeldingSymbol.h
View File

@@ -175,8 +175,8 @@ class TaskDlgWeldingSymbol : public Gui::TaskView::TaskDialog
Q_OBJECT
public:
TaskDlgWeldingSymbol(TechDraw::DrawLeaderLine* leader);
TaskDlgWeldingSymbol(TechDraw::DrawWeldSymbol* weld);
explicit TaskDlgWeldingSymbol(TechDraw::DrawLeaderLine* leader);
explicit TaskDlgWeldingSymbol(TechDraw::DrawWeldSymbol* weld);
~TaskDlgWeldingSymbol() override;
public: