kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Fem: [skip ci] improve implementation of TaskFemConstraintForce::onButtonDirection

Browse Source
This commit is contained in:
wmayer
2020-02-26 12:50:10 +01:00
parent e2d2101996
commit 1b57cd3ae2
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/Mod/Fem/Gui/TaskFemConstraintForce.cpp
View File

@@ -275,55 +275,55 @@ void TaskFemConstraintForce::onButtonDirection(const bool pressed)
//get vector of selected objects of active document
std::vector<Gui::SelectionObject> selection = Gui::Selection().getSelectionEx();
if (selection.size() == 0) {
QMessageBox::warning(this, tr("Selection error"), tr("Nothing selected!"));
QMessageBox::warning(this, tr("Empty selection"), tr("Select an edge or a face, please."));
return;
}
Fem::ConstraintForce* pcConstraint = static_cast<Fem::ConstraintForce*>(ConstraintView->getObject());
// we only handle the first selected object
std::vector<Gui::SelectionObject>::iterator selectionElement = selection.begin();
std::string TypeName = static_cast<std::string>(selectionElement->getTypeName());
Gui::SelectionObject& selectionElement = selection.at(0);
// we can only handle part objects
if (TypeName.substr(0, 4).compare(std::string("Part")) != 0) {
QMessageBox::warning(this, tr("Selection error"), tr("Selected object is not a part!"));
if (!selectionElement.isObjectTypeOf(Part::Feature::getClassTypeId())) {
QMessageBox::warning(this, tr("Wrong selection"), tr("Selected object is not a part object!"));
return;
}
// get the names of the subobjects
std::vector<std::string> subNames = selectionElement->getSubNames();
const std::vector<std::string>& subNames = selectionElement.getSubNames();
if (subNames.size() > 1) {
QMessageBox::warning(this, tr("Selection error"), tr("Only one planar face or edge can be selected!"));
if (subNames.size() != 1) {
QMessageBox::warning(this, tr("Wrong selection"), tr("Only one planar face or edge can be selected!"));
return;
}
// we are now sure we only have one object
std::string subNamesElement = subNames[0];
// vector for the direction
std::vector<std::string> direction(1, subNamesElement);
App::DocumentObject* obj = ConstraintView->getObject()->getDocument()->getObject(selectionElement->getFeatName());
Part::Feature* feat = static_cast<Part::Feature*>(obj);
Part::Feature* feat = static_cast<Part::Feature*>(selectionElement.getObject());
TopoDS_Shape ref = feat->Shape.getShape().getSubShape(subNamesElement.c_str());
if (subNamesElement.substr(0, 4) == "Face") {
if (!Fem::Tools::isPlanar(TopoDS::Face(ref))) {
QMessageBox::warning(this, tr("Selection error"), tr("Only planar faces can be picked for 3D"));
QMessageBox::warning(this, tr("Wrong selection"), tr("Only planar faces can be picked for 3D"));
return;
}
}
else if (subNamesElement.substr(0, 4) == "Edge") { // 2D or 3D can use edge as direction vector
if (!Fem::Tools::isLinear(TopoDS::Edge(ref))) {
QMessageBox::warning(this, tr("Selection error"), tr("Only planar edges can be picked for 2D"));
QMessageBox::warning(this, tr("Wrong selection"), tr("Only planar edges can be picked for 2D"));
return;
}
}
else {
QMessageBox::warning(this, tr("Selection error"), tr("Only faces for 3D part or edges for 2D can be picked"));
QMessageBox::warning(this, tr("Wrong selection"), tr("Only faces for 3D part or edges for 2D can be picked"));
return;
}
// update the direction
pcConstraint->Direction.setValue(obj, direction);
ui->lineDirection->setText(makeRefText(obj, subNamesElement));
pcConstraint->Direction.setValue(feat, direction);
ui->lineDirection->setText(makeRefText(feat, subNamesElement));
//Update UI
updateUI();