PartDesign: Improve Helix parameter proposals

The previous initial proposed parameters could cause self intersection when the user switches axis
2021-02-15 14:33:36 +01:00
parent 8d2b4d635f
commit 1d0466d6f2
1 changed files with 6 additions and 1 deletions
--- a/src/Mod/PartDesign/App/FeatureHelix.cpp
+++ b/src/Mod/PartDesign/App/FeatureHelix.cpp
@@ -504,7 +504,12 @@ double Helix::safePitch()
 void Helix::proposeParameters(bool force)
 {
    if (force || !HasBeenEdited.getValue()) {
-        double pitch = 1.1*safePitch();
+        TopoDS_Shape sketchshape = getVerifiedFace();
+        Bnd_Box bb;
+        BRepBndLib::Add(sketchshape, bb);
+        bb.SetGap(0.0);
+        double pitch = 1.1 * sqrt(bb.SquareExtent());
+
        Pitch.setValue(pitch);
        Height.setValue(pitch*3.0);
        HasBeenEdited.setValue(1);