kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: Fix bug angle via point visualisation

Browse Source 
===============================================

Issue description:
https://forum.freecad.org/viewtopic.php?f=3&t=70325
https://github.com/FreeCAD/FreeCAD/issues/7520

The general algorithm to calculate normals miserably fails when
the curve is a line segment and the point through which the normal
to a curve is to be drawn is colinear with the line segment.

The solution is to provide specific code for this corner case.

fixes #7520
This commit is contained in:
Abdullah Tahiri
2023-05-27 21:35:01 +02:00
committed by abdullahtahiriyo
parent 21223c8227
commit 1d61ed187c
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/Mod/Sketcher/Gui/EditModeConstraintCoinManager.cpp
View File

@@ -143,17 +143,25 @@ Restart:
auto geom = geolistfacade.getGeometryFromGeoId(geoid);
auto curve = dynamic_cast<const Part::GeomCurve*>(geom);
Base::Vector3d normal;
try {
if (!(curve && curve->normalAt(pointoncurve, normal))) {
auto line = dynamic_cast<const Part::GeomLineSegment*>(curve);
if (line) {
Base::Vector3d linedir = line->getEndPoint() - line->getStartPoint();
return Base::Vector3d(-linedir.y, linedir.x, 0);
}
else {
Base::Vector3d normal;
try {
if (!(curve && curve->normalAt(pointoncurve, normal))) {
normal = Base::Vector3d(1, 0, 0);
}
}
catch (const Base::CADKernelError&) {
normal = Base::Vector3d(1, 0, 0);
}
}
catch (const Base::CADKernelError&) {
normal = Base::Vector3d(1, 0, 0);
}
return normal;
return normal;
}
};
// go through the constraints and update the position