kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

TechDraw: Replace dynamic_cast with qobject_cast

Browse Source
This commit is contained in:
Kacper Donat
2025-04-07 20:00:03 +02:00
committed by Benjamin Nauck
parent 6e2583cdcd
commit 216166d853
6 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/TechDraw/Gui/CommandCreateDims.cpp
View File

@@ -120,7 +120,7 @@ void positionDimText(DrawViewDimension* dim, int indexOffset = 0);
void activateHandler(TechDrawHandler* newHandler)
{
auto* mdi = dynamic_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
auto* mdi = qobject_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
if (!mdi) {
return;
}
@@ -237,7 +237,7 @@ public:
void activated() override
{
auto* mdi = dynamic_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
auto* mdi = qobject_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
if (mdi) {
mdi->setDimensionsSelectability(false);
}
@@ -248,7 +248,7 @@ public:
void deactivated() override
{
auto* mdi = dynamic_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
auto* mdi = qobject_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
if (mdi) {
mdi->setDimensionsSelectability(true);
}

2
src/Mod/TechDraw/Gui/CommandDecorate.cpp
View File

@@ -349,7 +349,7 @@ void CmdTechDrawToggleFrame::activated(int iMsg)
// currently looking at that page
bool CmdTechDrawToggleFrame::isActive()
{
auto mvp = dynamic_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
auto mvp = qobject_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
if (!mvp) {
return false;
}

2
src/Mod/TechDraw/Gui/DrawGuiUtil.cpp
View File

@@ -353,7 +353,7 @@ TechDraw::DrawPage* DrawGuiUtil::findPage(Gui::Command* cmd, bool findAny)
// multiple pages in document, use active page if there is one
auto* w = Gui::getMainWindow();
auto* mv = w->activeWindow();
auto* mvp = dynamic_cast<MDIViewPage*>(mv);
auto* mvp = qobject_cast<MDIViewPage*>(mv);
if (mvp) {
QGSPage* qp = mvp->getViewProviderPage()->getQGSPage();
return qp->getDrawPage();

2
src/Mod/TechDraw/Gui/TaskLineDecor.cpp
View File

@@ -460,7 +460,7 @@ TaskDlgLineDecor::TaskDlgLineDecor(TechDraw::DrawViewPart* partFeat,
taskbox->hideGroupBox();
}
TaskLineDecor* parent = dynamic_cast<TaskLineDecor*>(widget);
TaskLineDecor* parent = qobject_cast<TaskLineDecor*>(widget);
if (parent) {
restore = new TaskRestoreLines(partFeat, parent);
restoreBox = new Gui::TaskView::TaskBox(Gui::BitmapFactory().pixmap("actions/TechDraw_DecorateLine"),

4
src/Mod/TechDraw/Gui/TechDrawHandler.cpp
View File

@@ -58,7 +58,7 @@ TechDrawHandler::~TechDrawHandler()
void TechDrawHandler::activate(QGVPage* vp)
{
auto* mdi = dynamic_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
auto* mdi = qobject_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
if (!mdi) {
return;
}
@@ -79,7 +79,7 @@ void TechDrawHandler::deactivate()
// So to prevent the menu from appearing when the tool is cleared by right mouse click
// we set a small timer.
QTimer::singleShot(100, []() { // 100 milliseconds delay
auto* mdi = dynamic_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
auto* mdi = qobject_cast<MDIViewPage*>(Gui::getMainWindow()->activeWindow());
if (!mdi) {
return;
}

2
src/Mod/TechDraw/Gui/ViewProviderDimension.cpp
View File

@@ -306,7 +306,7 @@ bool ViewProviderDimension::onDelete(const std::vector<std::string> & parms)
{
Q_UNUSED(parms)
auto dlg = Gui::Control().activeDialog();
auto ourDlg = dynamic_cast<TaskDlgDimension*>(dlg);
auto ourDlg = qobject_cast<TaskDlgDimension*>(dlg);
if (ourDlg) {
QString bodyMessage;
QTextStream bodyMessageStream(&bodyMessage);