[Bugfix] PartDesign: Fix HoleCutDepth not being recalculated correctly

HoleCutDepth is reset to 0 to force a recalculation of te depth when
HoleCutType is set to a new value.
But the line
	pcHole->HoleCutCustomValues.setValue(false)
also forces a recalculation. So the depth was recalculated with the old
value in HoleCutType which was not expected behaviour.
This commit is contained in:
Stefan Klug
2022-10-18 23:28:06 +02:00
committed by Uwe
parent 2973da9203
commit 264d0bb890

View File

@@ -342,6 +342,7 @@ void TaskHoleParameters::holeCutTypeChanged(int index)
// the HoleCutDepth is something different for countersinks and counterbores
// therefore reset it, it will be reset to sensible values by setting the new HoleCutType
pcHole->HoleCutDepth.setValue(0.0);
pcHole->HoleCutType.setValue(index);
// when holeCutType was changed, reset HoleCutCustomValues to false because it should
// be a purpose decision to overwrite the normed values
@@ -349,8 +350,6 @@ void TaskHoleParameters::holeCutTypeChanged(int index)
ui->HoleCutCustomValues->setChecked(false);
pcHole->HoleCutCustomValues.setValue(false);
pcHole->HoleCutType.setValue(index);
// recompute to get the info about the HoleCutType properties
recomputeFeature();