Part: for Prism feature use PrismExtension

This commit is contained in:
wmayer
2021-04-05 13:25:19 +02:00
parent fd7d4c91e8
commit 2b09a3ebec
2 changed files with 6 additions and 17 deletions

View File

@@ -573,12 +573,9 @@ Prism::Prism(void)
ADD_PROPERTY_TYPE(Polygon, (6.0), "Prism", App::Prop_None, "Number of sides in the polygon, of the prism");
ADD_PROPERTY_TYPE(Circumradius, (2.0), "Prism", App::Prop_None, "Circumradius (centre to vertex) of the polygon, of the prism");
ADD_PROPERTY_TYPE(Height, (10.0f), "Prism", App::Prop_None, "The height of the prism");
ADD_PROPERTY_TYPE(FirstAngle, (0.0f), "Prism", App::Prop_None, "Angle in first direction");
ADD_PROPERTY_TYPE(SecondAngle, (0.0f), "Prism", App::Prop_None, "Angle in second direction");
Polygon.setConstraints(&polygonRange);
static const App::PropertyQuantityConstraint::Constraints angleConstraint = { -89.99999, 89.99999, 1.0 };
FirstAngle.setConstraints(&angleConstraint);
SecondAngle.setConstraints(&angleConstraint);
PrismExtension::initExtension(this);
}
short Prism::mustExecute() const
@@ -589,10 +586,6 @@ short Prism::mustExecute() const
return 1;
if (Height.isTouched())
return 1;
if (FirstAngle.isTouched())
return 1;
if (SecondAngle.isTouched())
return 1;
return Primitive::mustExecute();
}
@@ -621,11 +614,7 @@ App::DocumentObjectExecReturn *Prism::execute(void)
mkPoly.Add(gp_Pnt(v.x,v.y,v.z));
BRepBuilderAPI_MakeFace mkFace(mkPoly.Wire());
// the direction vector for the prism is the height for z and the given angle
BRepPrimAPI_MakePrism mkPrism(mkFace.Face(),
gp_Vec(Height.getValue() * tan(Base::toRadians<double>(FirstAngle.getValue())),
Height.getValue() * tan(Base::toRadians<double>(SecondAngle.getValue())),
Height.getValue()));
this->Shape.setValue(mkPrism.Shape());
this->Shape.setValue(makePrism(Height.getValue(), mkFace.Face()));
}
catch (Standard_Failure& e) {
return new App::DocumentObjectExecReturn(e.GetMessageString());

View File

@@ -27,6 +27,7 @@
#include <App/PropertyUnits.h>
#include "PartFeature.h"
#include "AttachExtension.h"
#include "PrismExtension.h"
namespace Part
{
@@ -199,7 +200,8 @@ public:
//@}
};
class PartExport Prism : public Primitive
class PartExport Prism : public Primitive,
public PrismExtension
{
PROPERTY_HEADER(Part::Prism);
@@ -209,8 +211,6 @@ public:
App::PropertyIntegerConstraint Polygon;
App::PropertyLength Circumradius;
App::PropertyLength Height;
App::PropertyAngle FirstAngle;
App::PropertyAngle SecondAngle;
/** @name methods override feature */
//@{