kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Path: Fix automatic commitTransaction() calls, issue #6149 [Bug]

Browse Source 
This commit removes the automatic committal of transactions when activated with GUI command.  The committal of the transaction is executed with the `accept()` and `reject()` methods of the respective task panel.
This commit is contained in:
Russell Johnson
2022-03-12 22:05:04 -06:00
parent 73e995a0f7
commit 2bc14f84aa
8 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/Path/PathScripts/PathDressupAxisMap.py
View File

@@ -317,7 +317,7 @@ class CommandPathDressup:
"Gui.ActiveDocument.getObject(base.Name).Visibility = False"
)
FreeCADGui.doCommand("obj.ViewObject.Document.setEdit(obj.ViewObject, 0)")
FreeCAD.ActiveDocument.commitTransaction()
# FreeCAD.ActiveDocument.commitTransaction() # Final `commitTransaction()` called via TaskPanel.accept()
FreeCAD.ActiveDocument.recompute()

2
src/Mod/Path/PathScripts/PathDressupDogbone.py
View File

@@ -1400,7 +1400,7 @@ class CommandDressupDogbone(object):
"PathScripts.PathDressupDogbone.Create(FreeCAD.ActiveDocument.%s)"
% baseObject.Name
)
FreeCAD.ActiveDocument.commitTransaction()
# FreeCAD.ActiveDocument.commitTransaction() # Final `commitTransaction()` called via TaskPanel.accept()
FreeCAD.ActiveDocument.recompute()

2
src/Mod/Path/PathScripts/PathDressupDragknife.py
View File

@@ -660,7 +660,7 @@ class CommandDressupDragknife:
FreeCADGui.doCommand("obj.pivotheight = 4")
FreeCADGui.doCommand("obj.ViewObject.Document.setEdit(obj.ViewObject, 0)")
FreeCAD.ActiveDocument.commitTransaction()
# FreeCAD.ActiveDocument.commitTransaction() # Final `commitTransaction()` called via TaskPanel.accept()
FreeCAD.ActiveDocument.recompute()

2
src/Mod/Path/PathScripts/PathDressupLeadInOut.py
View File

@@ -732,7 +732,7 @@ class CommandPathDressupLeadInOut:
FreeCADGui.doCommand(
"Gui.ActiveDocument.getObject(base.Name).Visibility = False"
)
FreeCAD.ActiveDocument.commitTransaction()
# FreeCAD.ActiveDocument.commitTransaction() # Final `commitTransaction()` called via TaskPanel.accept()
FreeCAD.ActiveDocument.recompute()

2
src/Mod/Path/PathScripts/PathDressupPathBoundaryGui.py
View File

@@ -294,7 +294,7 @@ class CommandPathDressupPathBoundary:
"PathScripts.PathDressupPathBoundaryGui.Create(App.ActiveDocument.%s)"
% baseObject.Name
)
FreeCAD.ActiveDocument.commitTransaction()
# FreeCAD.ActiveDocument.commitTransaction() # Final `commitTransaction()` called via TaskPanel.accept()
FreeCAD.ActiveDocument.recompute()

2
src/Mod/Path/PathScripts/PathDressupRampEntry.py
View File

@@ -956,7 +956,7 @@ class CommandPathDressupRampEntry:
"Gui.ActiveDocument.getObject(base.Name).Visibility = False"
)
FreeCADGui.doCommand("dbo.setup(obj)")
FreeCAD.ActiveDocument.commitTransaction()
# FreeCAD.ActiveDocument.commitTransaction() # Final `commitTransaction()` called via TaskPanel.accept()
FreeCAD.ActiveDocument.recompute()

2
src/Mod/Path/PathScripts/PathDressupTagGui.py
View File

@@ -593,7 +593,7 @@ class CommandPathDressupTag:
"PathScripts.PathDressupTagGui.Create(App.ActiveDocument.%s)"
% baseObject.Name
)
FreeCAD.ActiveDocument.commitTransaction()
# FreeCAD.ActiveDocument.commitTransaction() # Final `commitTransaction()` called via TaskPanel.accept()
FreeCAD.ActiveDocument.recompute()

2
src/Mod/Path/PathScripts/PathDressupZCorrect.py
View File

@@ -396,7 +396,7 @@ class CommandPathDressup:
"Gui.ActiveDocument.getObject(obj.Base.Name).Visibility = False"
)
FreeCADGui.doCommand("obj.ViewObject.Document.setEdit(obj.ViewObject, 0)")
FreeCAD.ActiveDocument.commitTransaction()
# FreeCAD.ActiveDocument.commitTransaction() # Final `commitTransaction()` called via TaskPanel.accept()
FreeCAD.ActiveDocument.recompute()