kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: Fix external geometry out-of-bounds vector access (#22181)

Browse Source 
* Sketcher: Fix external geometry out-of-bounds vector access

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
Co-authored-by: Ajinkya Dahale <AjinkyaDahale@users.noreply.github.com>
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com>
This commit is contained in:
Johannes Wüller
2025-07-29 20:36:17 +02:00
committed by GitHub
parent d200ae6f7a
commit 3321b13218
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/Sketcher/App/SketchObject.cpp
View File

@@ -7134,9 +7134,7 @@ int SketchObject::addExternal(App::DocumentObject* Obj,
std::vector<long> Types = ExternalTypes.getValues();
std::vector<DocumentObject*> Objects = ExternalGeometry.getValues();
std::vector<std::string> SubElements = ExternalGeometry.getSubValues();
if (Types.size() != Objects.size()) {
Types.resize(Objects.size(), 0);
}
Types.resize(Objects.size(), static_cast<long>(ExtType::Projection));
const std::vector<DocumentObject*> originalObjects = Objects;
const std::vector<std::string> originalSubElements = SubElements;
@@ -8763,9 +8761,7 @@ void SketchObject::rebuildExternalGeometry(std::optional<ExternalToAdd> extToAdd
BRepBuilderAPI_MakeFace mkFace(sketchPlane);
TopoDS_Shape aProjFace = mkFace.Shape();
if (Types.size() != Objects.size()) {
Types.resize(Objects.size(), 0);
}
Types.resize(Objects.size(), static_cast<long>(ExtType::Projection));
std::set<std::string> refSet;
// We use a vector here to keep the order (roughly) the same as ExternalGeometry