kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[Sketcher] Constrain new B-spline pole weight only if equal to first

Browse Source 
When new control points are created in a b-spline in a sketch, do not constrain
their weights to be equal to the first, unless they are already equal. This way
if we have unequal weights to begin with and OCC has computed the appropriate
weights so that the new spline is closer to the original, the weights are not
disturbed.
This commit is contained in:
Ajinkya Dahale
2021-12-23 22:46:28 -05:00
committed by abdullahtahiriyo
parent ba78b194b3
commit 3bd2bcc72f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/Mod/Sketcher/App/SketchObject.cpp
View File

@@ -5160,6 +5160,7 @@ int SketchObject::exposeInternalGeometry(int GeoId)
std::vector<Constraint *> icon;
std::vector<Base::Vector3d> poles = bsp->getPoles();
std::vector<double> weights = bsp->getWeights();
std::vector<double> knots = bsp->getKnots();
double distance_p0_p1 = (poles[1]-poles[0]).Length(); // for visual purposes only
@@ -5187,10 +5188,9 @@ int SketchObject::exposeInternalGeometry(int GeoId)
icon.push_back(newConstr);
if(it != controlpointgeoids.begin()) {
// if pole-weight newly created AND first weight is radius-constrained,
// make it equal to first weight by default
if(isfirstweightconstrained) {
if(isfirstweightconstrained && weights[0] == weights[index]) {
// if pole-weight newly created AND first weight is radius-constrained,
// AND these weights are equal, constrain them to be equal
Sketcher::Constraint *newConstr2 = new Sketcher::Constraint();
newConstr2->Type = Sketcher::Equal;
newConstr2->First = currentgeoid+incrgeo+1;