kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Draft: fix Draft_Label MaxChars property (#27478)

Browse Source 
* Draft: fix Draft_Label MaxChars property

Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>

* Minor tweak: moved/replaced call to self.onChanged

---------

Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>
Co-authored-by: Roy-043 <70520633+Roy-043@users.noreply.github.com>
This commit is contained in:
Yash Suthar
2026-02-11 23:28:42 +05:30
committed by GitHub
parent ec18d4e250
commit 3d14203fa4
1 changed files with 26 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/Mod/Draft/draftviewproviders/view_label.py
View File

@@ -34,6 +34,7 @@
# @{
import math
import sys
import textwrap
import pivy.coin as coin
from PySide.QtCore import QT_TRANSLATE_NOOP
@@ -189,6 +190,21 @@ class ViewProviderLabel(ViewProviderDraftAnnotation):
self.onChanged(vobj, "ArrowSizeStart")
self.onChanged(vobj, "Line")
def update_text(self, obj, vobj):
"""Update the text string in the scene, wrapping it if needed."""
self.text_wld.string.setValue("")
self.text_scr.string.setValue("")
_list = [l for l in obj.Text if l] if obj.Text else []
if _list and hasattr(vobj, "MaxChars") and vobj.MaxChars > 0:
new_list = []
for line in _list:
new_list.extend(textwrap.wrap(line, vobj.MaxChars))
_list = new_list
self.text_wld.string.setValues(_list)
self.text_scr.string.setValues(_list)
def updateData(self, obj, prop):
"""Execute when a property from the Proxy class is changed."""
vobj = obj.ViewObject
@@ -222,20 +238,11 @@ class ViewProviderLabel(ViewProviderDraftAnnotation):
if vobj.Justification == "Right":
vobj.Justification = "Left"
self.onChanged(
obj.ViewObject, "DisplayMode"
) # Property to trigger update_label and update_frame.
# We could have used a different property.
self.onChanged(vobj, "DisplayMode") # trigger update_label and update_frame.
elif prop == "Text" and obj.Text:
self.text_wld.string.setValue("")
self.text_scr.string.setValue("")
_list = [l for l in obj.Text if l]
self.text_wld.string.setValues(_list)
self.text_scr.string.setValues(_list)
self.onChanged(obj.ViewObject, "DisplayMode")
self.update_text(obj, vobj)
self.onChanged(vobj, "DisplayMode") # idem
def onChanged(self, vobj, prop):
"""Execute when a view property is changed."""
@@ -269,6 +276,13 @@ class ViewProviderLabel(ViewProviderDraftAnnotation):
if can_update_frame:
self.update_frame(obj, vobj)
elif prop == "MaxChars" and "MaxChars" in properties:
self.update_text(obj, vobj)
if can_update_label:
self.update_label(obj, vobj)
if can_update_frame:
self.update_frame(obj, vobj)
elif prop == "ScaleMultiplier" and "ScaleMultiplier" in properties:
if "ArrowSizeStart" in properties:
s = vobj.ArrowSizeStart.Value * vobj.ScaleMultiplier