kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

[Sketcher][planegcs] Fix tangent at knot for C1 knots

Browse Source
This commit is contained in:
Ajinkya Dahale
2022-11-11 01:06:45 +05:30
committed by Chris Hennes
parent af5bc953c9
commit 3f91c52b3f
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/Mod/Sketcher/App/planegcs/Constraints.cpp
View File

@@ -283,12 +283,9 @@ ConstraintSlopeAtBSplineKnot::ConstraintSlopeAtBSplineKnot(BSpline& b, Line& l,
factors.resize(numpoles);
slopefactors.resize(numpoles);
for (size_t i = 0; i < numpoles + 1; ++i) {
// FIXME: `getLinCombFactor` seg-faults for the last knot so this safeguard exists
if (numpoles > 2) {
tempfactors[i] =
b.getLinCombFactor(*(b.knots[knotindex]), startpole + b.degree, startpole + i, b.degree - 1) /
(b.flattenedknots[startpole + b.degree + i] - b.flattenedknots[startpole + i]);
}
tempfactors[i] =
b.getLinCombFactor(*(b.knots[knotindex]), startpole + b.degree, startpole + i, b.degree - 1) /
(b.flattenedknots[startpole + b.degree + i] - b.flattenedknots[startpole + i]);
}
for (size_t i = 0; i < numpoles; ++i) {
factors[i] =