kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

TD: further security checks in CmdTechDrawExtensionPositionSectionView::activated

Browse Source
This commit is contained in:
wmayer
2022-02-28 19:09:31 +01:00
parent 13e7d47154
commit 420fbb3d28
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Mod/TechDraw/Gui/CommandExtensionPack.cpp
View File

@@ -1446,10 +1446,11 @@ void CmdTechDrawExtensionPositionSectionView::activated(int iMsg) {
QObject::tr("Selection is empty"));
return;
}
float xPos=0.0f, yPos=0.0f;
double xPos=0.0, yPos=0.0;
TechDraw::DrawViewPart* baseView;
auto objFeat = selection[0].getObject();
if (objFeat->isDerivedFrom(TechDraw::DrawViewSection::getClassTypeId())) {
if (objFeat && objFeat->isDerivedFrom(TechDraw::DrawViewSection::getClassTypeId())) {
TechDraw::DrawViewSection* sectionView = static_cast<TechDraw::DrawViewSection*>(objFeat);
baseView = sectionView->getBaseDVP();
if (baseView && baseView->isDerivedFrom(TechDraw::DrawProjGroupItem::getClassTypeId())) {
@@ -1462,7 +1463,7 @@ void CmdTechDrawExtensionPositionSectionView::activated(int iMsg) {
}
}
}
else {
else if (baseView) {
xPos = baseView->X.getValue();
yPos = baseView->Y.getValue();
}