kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Core: Fix false-positive in migrateXAxisPlacement()

Browse Source 
Use a looser tolerance to compare the rotations of the axes and planes of the coordinate system
This commit is contained in:
wmayer
2024-12-14 21:36:25 +01:00
committed by wwmayer
parent 568c869dcb
commit 43f28b63a8
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/App/Datums.cpp
View File

@@ -306,6 +306,7 @@ void LocalCoordinateSystem::migrateOriginPoint()
void LocalCoordinateSystem::migrateXAxisPlacement()
{
constexpr const double tolerance = 1e-5;
auto features = OriginFeatures.getValues();
migrated = false;
@@ -317,10 +318,11 @@ void LocalCoordinateSystem::migrateXAxisPlacement()
for (auto data : setupData) {
// ensure the rotation is correct for the role
if (std::strcmp(feature->Role.getValue(), data.role) == 0) {
if (!feature->Placement.getValue().getRotation().isSame(data.rot)) {
if (!feature->Placement.getValue().getRotation().isSame(data.rot, tolerance)) {
feature->Placement.setValue(Base::Placement(Base::Vector3d(), data.rot));
migrated = true;
}
break;
}
}
}