kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PD: [skip ci] fix regression caused by e0d07257b7

Browse Source 
In the accept() method the view provider of the edited object must be made visible if it's valid as otherwise it can happen that the view is empty.

See https://forum.freecadweb.org/viewtopic.php?f=13&t=55915
This commit is contained in:
wmayer
2021-02-23 11:20:45 +01:00
parent 7659bb0dae
commit 482884cfd4
4 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Mod/PartDesign/Gui/TaskChamferParameters.cpp
View File

@@ -404,6 +404,10 @@ TaskDlgChamferParameters::~TaskDlgChamferParameters()
//}
bool TaskDlgChamferParameters::accept()
{
auto obj = vp->getObject();
if (!obj->isError())
parameter->showObject();
parameter->apply();
return TaskDlgDressUpParameters::accept();

5
src/Mod/PartDesign/Gui/TaskDraftParameters.cpp
View File

@@ -386,6 +386,10 @@ TaskDlgDraftParameters::~TaskDlgDraftParameters()
bool TaskDlgDraftParameters::accept()
{
auto tobj = vp->getObject();
if (!tobj->isError())
parameter->showObject();
std::vector<std::string> strings;
App::DocumentObject* obj;
TaskDraftParameters* draftparameter = static_cast<TaskDraftParameters*>(parameter);
@@ -403,7 +407,6 @@ bool TaskDlgDraftParameters::accept()
// return false;
// }
auto tobj = vp->getObject();
FCMD_OBJ_CMD(tobj,"Angle = " << draftparameter->getAngle());
FCMD_OBJ_CMD(tobj,"Reversed = " << draftparameter->getReversed());
if(neutralPlane.empty())

4
src/Mod/PartDesign/Gui/TaskFilletParameters.cpp
View File

@@ -281,6 +281,10 @@ TaskDlgFilletParameters::~TaskDlgFilletParameters()
//}
bool TaskDlgFilletParameters::accept()
{
auto obj = vp->getObject();
if (!obj->isError())
parameter->showObject();
parameter->apply();
return TaskDlgDressUpParameters::accept();

6
src/Mod/PartDesign/Gui/TaskThicknessParameters.cpp
View File

@@ -363,9 +363,11 @@ TaskDlgThicknessParameters::~TaskDlgThicknessParameters()
bool TaskDlgThicknessParameters::accept()
{
TaskThicknessParameters* draftparameter = static_cast<TaskThicknessParameters*>(parameter);
auto obj = vp->getObject();
if (!obj->isError())
parameter->showObject();
TaskThicknessParameters* draftparameter = static_cast<TaskThicknessParameters*>(parameter);
FCMD_OBJ_CMD(obj,"Value = " << draftparameter->getValue());
FCMD_OBJ_CMD(obj,"Reversed = " << draftparameter->getReversed());