kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: Remove redundant checks

Browse Source 
Also cleanup missing curly braces.
This commit is contained in:
Chris Hennes
2025-06-15 20:59:54 -05:00
committed by Kacper Donat
parent ac51f11660
commit 484904e9e1
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/Sketcher/App/SketchObject.cpp
View File

@@ -1784,8 +1784,9 @@ int SketchObject::delGeometry(int GeoId, bool deleteinternalgeo)
Base::StateLocker lock(managedoperation, true);
const std::vector<Part::Geometry*>& vals = getInternalGeometry();
if (GeoId < 0 || GeoId >= int(vals.size()))
if (GeoId >= int(vals.size())) {
return -1;
}
if (deleteinternalgeo && hasInternalGeometry(getGeometry(GeoId))) {
// Only for supported types
@@ -7568,8 +7569,9 @@ const Part::Geometry* SketchObject::_getGeometry(int GeoId) const
if (GeoId < int(geomlist.size()))
return geomlist[GeoId];
}
else if (GeoId < 0 && -GeoId-1 < ExternalGeo.getSize())
else if (-GeoId-1 < ExternalGeo.getSize()) {
return ExternalGeo[-GeoId-1];
}
return nullptr;
}