kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Mesh: [skip ci] Fix coverity warning

Browse Source 
Coverity warnings fixed:

CID 316517 (#1 of 1): Uninitialized scalar variable (UNINIT)
13. uninit_use_in_call: Using uninitialized value t. Field t.err is uninitialized when calling push_back

CID 316519 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value v. Field v.tstart is uninitialized when calling push_back

CID 316547 (#1 of 1): Uninitialized scalar variable (UNINIT)
13. uninit_use_in_call: Using uninitialized value t. Field t.err is uninitialized when calling push_back

CID 316556 (#1 of 1): Uninitialized scalar variable (UNINIT)
3. uninit_use_in_call: Using uninitialized value v. Field v.tstart is uninitialized when calling push_back
This commit is contained in:
wmayer
2021-02-21 15:51:56 +01:00
parent cc4824680b
commit 4a2d131cb6
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/Mesh/App/Core/Decimation.cpp
View File

@@ -52,6 +52,7 @@ void MeshSimplify::simplify(float tolerance, float reduction)
const MeshPointArray& points = myKernel.GetPoints(); const MeshPointArray& points = myKernel.GetPoints();
for (std::size_t i = 0; i < points.size(); i++) { for (std::size_t i = 0; i < points.size(); i++) {
Simplify::Vertex v; Simplify::Vertex v;
v.tstart = 0;
v.p = points[i]; v.p = points[i];
alg.vertices.push_back(v); alg.vertices.push_back(v);
} }
@@ -59,6 +60,8 @@ void MeshSimplify::simplify(float tolerance, float reduction)
const MeshFacetArray& facets = myKernel.GetFacets(); const MeshFacetArray& facets = myKernel.GetFacets();
for (std::size_t i = 0; i < facets.size(); i++) { for (std::size_t i = 0; i < facets.size(); i++) {
Simplify::Triangle t; Simplify::Triangle t;
for (int j = 0; j < 4; j++)
t.err[j] = 0.0;
for (int j = 0; j < 3; j++) for (int j = 0; j < 3; j++)
t.v[j] = facets[i]._aulPoints[j]; t.v[j] = facets[i]._aulPoints[j];
alg.triangles.push_back(t); alg.triangles.push_back(t);
@@ -103,6 +106,7 @@ void MeshSimplify::simplify(int targetSize)
const MeshPointArray& points = myKernel.GetPoints(); const MeshPointArray& points = myKernel.GetPoints();
for (std::size_t i = 0; i < points.size(); i++) { for (std::size_t i = 0; i < points.size(); i++) {
Simplify::Vertex v; Simplify::Vertex v;
v.tstart = 0;
v.p = points[i]; v.p = points[i];
alg.vertices.push_back(v); alg.vertices.push_back(v);
} }
@@ -110,6 +114,8 @@ void MeshSimplify::simplify(int targetSize)
const MeshFacetArray& facets = myKernel.GetFacets(); const MeshFacetArray& facets = myKernel.GetFacets();
for (std::size_t i = 0; i < facets.size(); i++) { for (std::size_t i = 0; i < facets.size(); i++) {
Simplify::Triangle t; Simplify::Triangle t;
for (int j = 0; j < 4; j++)
t.err[j] = 0.0;
for (int j = 0; j < 3; j++) for (int j = 0; j < 3; j++)
t.v[j] = facets[i]._aulPoints[j]; t.v[j] = facets[i]._aulPoints[j];
alg.triangles.push_back(t); alg.triangles.push_back(t);