kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PD: [skip ci] fix minor issues:

Browse Source 
* don't need to clear an empty vector
* remove two code blocks that effectively do nothing (except of producing a warning :) )
This commit is contained in:
wmayer
2021-09-28 15:43:25 +02:00
parent 1f6d3cb03b
commit 4a47b98b16
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Mod/PartDesign/Gui/TaskPadParameters.cpp
View File

@@ -355,7 +355,6 @@ void TaskPadParameters::fillDirectionCombo()
if (axesInList.empty()) {
ui->directionCB->clear();
this->axesInList.clear();
// add sketch normal
PartDesign::ProfileBased* pcFeat = static_cast<PartDesign::ProfileBased*>(vp->getObject());
Part::Part2DObject* pcSketch = dynamic_cast<Part::Part2DObject*>(pcFeat->Profile.getValue());
@@ -414,12 +413,6 @@ void TaskPadParameters::onDirectionCBChanged(int num)
if (axesInList.empty() || !pcPad)
return;
App::DocumentObject* oldRefAxis = propReferenceAxis->getValue();
std::vector<std::string> oldSubRefAxis = propReferenceAxis->getSubValues();
std::string oldRefName;
if (!oldSubRefAxis.empty())
oldRefName = oldSubRefAxis.front();
App::PropertyLinkSub& lnk = *(axesInList[num]);
if (lnk.getValue() == 0) {
// enter reference selection mode
@@ -440,12 +433,6 @@ void TaskPadParameters::onDirectionCBChanged(int num)
}
try {
App::DocumentObject* newRefAxis = propReferenceAxis->getValue();
const std::vector<std::string>& newSubRefAxis = propReferenceAxis->getSubValues();
std::string newRefName;
if (!newSubRefAxis.empty())
newRefName = newSubRefAxis.front();
recomputeFeature();
}
catch (const Base::Exception& e) {