kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: Emit signal to EditableDatumLabel only if there's no digits

Browse Source 
Small regression of mine, basically this signal to remove set/locked
state of EditableDatumLabel should be only sent out if current text in
the label is empty or it doesn't contain digits.

Previously it was emitted every intermediate wrong state, so stuff like
"71." was also being matched, and it resulted in resetting the locked
state of the label, which in turn resulted in keeping user from entering
float values.
This commit is contained in:
tetektoza
2025-06-17 00:25:16 +02:00
parent fca41e4003
commit 4b4475ea3f
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Gui/QuantitySpinBox.cpp
View File

@@ -572,10 +572,16 @@ void QuantitySpinBox::userInput(const QString & text)
else {
d->validInput = false;
// we have to emit here signal explicitly as validator will not pass
// this value further but we want to check it to disable isSet flag if
// it has been set previously
Q_EMIT valueChanged(d->quantity.getValue());
// only emit signal to reset EditableDatumLabel if the input is truly empty or has
// no meaningful number don't emit for partially typed numbers like "71." which are
// temporarily invalid
QString trimmedText = text.trimmed();
if (trimmedText.isEmpty() || !trimmedText.contains(QRegularExpression(QStringLiteral("[0-9]")))) {
// we have to emit here signal explicitly as validator will not pass
// this value further but we want to check it to disable isSet flag if
// it has been set previously
Q_EMIT valueChanged(d->quantity.getValue());
}
return;
}