kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Sketcher: remove unneeded flag

Browse Source
This commit is contained in:
0penBrain
2022-10-21 14:56:30 +02:00
committed by wwmayer
parent 4fff36b550
commit 4c6ba8ed4d
2 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Mod/Sketcher/Gui/ViewProviderSketch.cpp
View File

@@ -3164,7 +3164,6 @@ void ViewProviderSketch::setEditViewer(Gui::View3DInventorViewer* viewer, int Mo
void ViewProviderSketch::unsetEditViewer(Gui::View3DInventorViewer* viewer)
{
auto dataPtr = static_cast<VPRender*>(cameraSensor.getData());
dataPtr->attached = false;
delete dataPtr;
cameraSensor.setData(nullptr);
cameraSensor.detach();
@@ -3178,7 +3177,7 @@ void ViewProviderSketch::unsetEditViewer(Gui::View3DInventorViewer* viewer)
void ViewProviderSketch::camSensCB(void *data, SoSensor *)
{
VPRender *proxyVPrdr = static_cast<VPRender*>(data);
if (!proxyVPrdr || !proxyVPrdr->attached)
if (!proxyVPrdr)
return;
auto vp = proxyVPrdr->vp;

4
src/Mod/Sketcher/Gui/ViewProviderSketch.h
View File

@@ -396,10 +396,6 @@ private:
struct VPRender {
ViewProviderSketch* vp;
SoRenderManager* renderMgr;
// we have to manage an internal flag because as sensor events are queued in Coin,
// it may happen that the callback is called while the sensor is detached,
// leading to subsequent code trying to access deleted objects (passed as sensor data)
bool attached = true;
};
public: