kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: property-editor open the combo directly and apply after selection

Browse Source 
Previously you had to make 4 clicks to apply a combo
1 to enter edit, 1 to open the combo, 1 to select, and 1 to defocus and apply

with this commit only 2 clicks:
1 to open the combo and 1 to select
This commit is contained in:
Alfredo Monclus
2025-05-25 03:35:42 -06:00
committed by Kacper Donat
parent e7882427e7
commit 4e387e3ff3
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/Gui/propertyeditor/PropertyItemDelegate.cpp
View File

@@ -25,6 +25,7 @@
#ifndef _PreComp_
# include <QApplication>
# include <QComboBox>
# include <QModelIndex>
# include <QPainter>
#endif
@@ -127,7 +128,16 @@ bool PropertyItemDelegate::editorEvent (QEvent * event, QAbstractItemModel* mode
bool PropertyItemDelegate::eventFilter(QObject *o, QEvent *ev)
{
if (ev->type() == QEvent::FocusOut) {
if (ev->type() == QEvent::FocusIn) {
auto *comboBox = qobject_cast<QComboBox*>(o);
if (comboBox) {
auto parentEditor = qobject_cast<PropertyEditor*>(this->parent());
if (parentEditor && parentEditor->activeEditor == comboBox) {
comboBox->showPopup();
}
}
}
else if (ev->type() == QEvent::FocusOut) {
auto parentEditor = qobject_cast<PropertyEditor*>(this->parent());
auto widget = qobject_cast<QWidget*>(o);
if (widget && parentEditor && parentEditor->activeEditor
@@ -218,6 +228,10 @@ void PropertyItemDelegate::valueChanged()
if (propertyEditor) {
Base::FlagToggler<> flag(changed);
Q_EMIT commitData(propertyEditor);
auto *comboBox = qobject_cast<QComboBox*>(propertyEditor);
if (comboBox) {
Q_EMIT closeEditor(propertyEditor);
}
}
}